[docs] Manage focus on Open in Chat button click - #48942
Open
silviuaavram wants to merge 1 commit into
Open
Conversation
silviuaavram
requested review from
ZeeshanTamboli,
brijeshb42,
sai6855 and
siriwatknp
and
a lite review from Copilot
August 10, 2026 09:02
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the docs “Edit in Chat” (Open in MUI Chat) experience by addressing focus loss after clicking the button, and by ensuring the button is re-enabled as soon as the request completes (even when an error toast is shown).
Changes:
- Add logic to restore focus to the “Edit in Chat” button after the loading state completes.
- Stop disabling the button based solely on the presence of an error toast.
- Add unit tests covering focus restoration on success, failure, and when the user moves focus elsewhere.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages-internal/core-docs/src/Demo/OpenInMUIChatButton.tsx | Adds focus-management logic tied to the loading lifecycle and adjusts ref handling. |
| packages-internal/core-docs/src/Demo/OpenInMUIChatButton.test.tsx | Introduces tests verifying focus restoration behavior across success/failure and user-driven focus changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+69
to
+77
| beforeEach(() => { | ||
| mocks.openSandbox.mockReset(); | ||
| vi.stubEnv('MUI_CHAT_API_BASE_URL', 'https://chat.example.com'); | ||
| vi.stubEnv('MUI_CHAT_SCOPES', 'material-ui'); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| vi.unstubAllEnvs(); | ||
| }); |
Member
Author
There was a problem hiding this comment.
We use vi functions in our tests, we should be fine with these as well.
Comment on lines
+103
to
+122
| const rainbowButtonRef = React.useRef<HTMLButtonElement | null>(null); | ||
| const handleRef = useForkRef<HTMLButtonElement>(ref, rainbowButtonRef); | ||
| const wasLoadingRef = React.useRef(false); | ||
|
|
||
| React.useEffect(() => { | ||
| if (wasLoadingRef.current && !loading) { | ||
| const rainbowButton = rainbowButtonRef.current; | ||
| const document = ownerDocument(rainbowButton); | ||
| const activeElement = getActiveElement(document); | ||
|
|
||
| if ( | ||
| activeElement === document.body || | ||
| activeElement === null || | ||
| activeElement === document.documentElement | ||
| ) { | ||
| rainbowButtonRef.current?.focus(); | ||
| } | ||
| } | ||
| wasLoadingRef.current = loading; | ||
| }, [loading]); |
Member
Author
There was a problem hiding this comment.
should be fine, if the user uses the mouse to interact, they don't care about focus being management at that point.
brijeshb42
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When clicking Open in Chat button in the docs, the focus is lost to the body. Restore the focus to the button once the button is not loading anymore, and if the user did not move focus elsewhere.
Also, there is no reason to disable the button while showing the error toast. Button should be enabled as soon as possible, when the request returns.