Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sync] Is not exporting all variables #446

Open
irlabs opened this issue Jan 28, 2025 · 0 comments
Open

[sync] Is not exporting all variables #446

irlabs opened this issue Jan 28, 2025 · 0 comments
Assignees
Labels
scope: sync Issues related to the Material UI Sync Figma plugin status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@irlabs
Copy link

irlabs commented Jan 28, 2025

Steps to reproduce

Steps:

  1. Create some custom action colors and set the disabled to 38% of #000000
  2. Click "Regenerate theme"
  3. Look at the generated JSON

Current behavior

  • When using 38% the JSON is omitting the token for colorSchemes.light.palette.action.disabled
  • When using 39% the JSON is including the token for colorSchemes.light.palette.action.disabled

See these screenshots:

With 38% opacity: value is not included:

Image

With 39% opacity: value is included

Image

Expected behavior

All the variables should be included as tokens in the generated theme.

(Especially regardless of some arbitrary opacity like 38% or 39%)

Context

I am creating custom color tokens and want to export them as JSON

Your environment

Software Version
Design file version v5.17.0
Design tool Figma
Material UI Sync tool v0.1 BETA

Search keywords: regenerate theme exporting tokens to JSON

@irlabs irlabs added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 28, 2025
@oliviertassinari oliviertassinari added the scope: sync Issues related to the Material UI Sync Figma plugin label Jan 29, 2025
@oliviertassinari oliviertassinari changed the title Sync tool is not exporting all variables [sync] Is not exporting all variables Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: sync Issues related to the Material UI Sync Figma plugin status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Development

No branches or pull requests

3 participants