Skip to content

Commit d33c915

Browse files
ntninjaStebalien
andauthored
Apply suggestions from code review
Co-Authored-By: Steven Allen <[email protected]>
1 parent 12a68ea commit d33c915

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ Examples of libraries for performing the above steps include the [Python idna](h
157157

158158
Encodes an IPv4 address according to the conventional [dot-decimal notation](https://en.wikipedia.org/wiki/Dot-decimal_notation) first specificed in [RFC 3986 section 3.2.2 page 20 § 2](https://tools.ietf.org/html/rfc3986#page-20).
159159

160-
Protocols using this codec may encode it as binary value of exactly 4 bytes without
160+
Protocols using this codec must encode it as binary value of exactly 4 bytes without
161161
an extra length value.
162162

163163
* String → Binary:
@@ -189,7 +189,7 @@ to string address transformation.
189189

190190
Encodes an IPv6 address according to the rules of [RFC 4291 section 2.2](https://tools.ietf.org/html/rfc4291#section-2.2) and [RFC 5962 section 4](https://tools.ietf.org/html/rfc5952#section-4).
191191

192-
Protocols using this codec may encode it as binary value of exactly 16 bytes without
192+
Protocols using this codec must encode it as binary value of exactly 16 bytes without
193193
an extra length value.
194194

195195
* String → Binary:
@@ -209,7 +209,7 @@ may be a viable alternative for some environments.
209209

210210
Encodes a [TOR rendezvous version 2 service pointer](https://gitweb.torproject.org/torspec.git/tree/rend-spec-v2.txt?id=471af27b55ff3894551109b45848f2ce1002441b#n525) (aka .onion-address) and exposed service port on that system.
211211

212-
Protocols using this codec may encode it as binary value of exactly 12 bytes without
212+
Protocols using this codec must encode it as binary value of exactly 12 bytes without
213213
an extra length value.
214214

215215
* String → Binary:
@@ -242,7 +242,7 @@ TBD: Is this really always a base58btc encoded string of at least 5 characters i
242242
Encodes an unsigned 16-bit integer value (such as a port number) in network byte
243243
order (big endian).
244244

245-
Protocols using this codec may encode it as binary value of exactly 2 bytes without
245+
Protocols using this codec must encode it as binary value of exactly 2 bytes without
246246
an extra length value.
247247

248248
* String → Binary:

0 commit comments

Comments
 (0)