Addendum to last. Downgrading seems counter-intuitive but it's to solve a netcode issue (temp solution)

Author: Dutchman101

Client/core/CModelCacheManager.cpp

@@ -136,7 +136,7 @@ class CModelCacheManagerImpl : public CModelCacheManager
     virtual void OnClientClose();
     virtual void UpdatePedModelCaching(const std::map<ushort, float>& newNeedCacheList);
     virtual void UpdateVehicleModelCaching(const std::map<ushort, float>& newNeedCacheList);
-    virtual void SetCustomLimits(std::optional<size_t> numVehicles, std::optional<size_t> numPeds);
+    virtual void SetCustomLimits(const size_t* numVehicles, const size_t* numPeds);
 
     // CModelCacheManagerImpl methods
     CModelCacheManagerImpl();
@@ -315,15 +315,15 @@ void CModelCacheManagerImpl::GetStats(SModelCacheStats& outStats)
 // CModelCacheManagerImpl::SetCustomLimits
 //
 // Function to set custom limits, instead of calculating them automatically.
-// If the optional is empty, the value is restored to the automatic one
-// otherwise it is set to whatever value the opt contains
+// If the pointer is nullptr, the value is restored to the automatic one
+// otherwise it is set to whatever value the pointer points to
 // 
 ///////////////////////////////////////////////////////////////
-void CModelCacheManagerImpl::SetCustomLimits(std::optional<size_t> numVehicles, std::optional<size_t> numPeds) {
-    if (m_IsUsingCustomPedCacheLimit = numPeds.has_value()) {
+void CModelCacheManagerImpl::SetCustomLimits(const size_t* numVehicles, const size_t* numPeds) {
+    if (m_IsUsingCustomPedCacheLimit = (numPeds != nullptr)) {
         m_uiMaxCachedPedModels = *numPeds;
     }
-    if (m_IsUsingCustomVehicleCacheLimit = numVehicles.has_value()) {
+    if (m_IsUsingCustomVehicleCacheLimit = (numVehicles != nullptr)) {
         m_uiMaxCachedVehicleModels = *numVehicles;
     }
 }

Client/core/CModelCacheManager.h

@@ -7,6 +7,10 @@
  *
  *****************************************************************************/
 
+#pragma once
+
+#include <map>
+
 struct SModelCacheStats;
 
 class CModelCacheManager
@@ -22,7 +26,7 @@ class CModelCacheManager
     virtual void OnClientClose() = 0;
     virtual void UpdatePedModelCaching(const std::map<ushort, float>& newNeedCacheList) = 0;
     virtual void UpdateVehicleModelCaching(const std::map<ushort, float>& newNeedCacheList) = 0;
-    virtual void SetCustomLimits(std::optional<size_t> numVehicles, std::optional<size_t> numPeds) = 0;
+    virtual void SetCustomLimits(const size_t* numVehicles, const size_t* numPeds) = 0;
 };
 
 CModelCacheManager* NewModelCacheManager();

Client/core/StdInc.h

@@ -32,7 +32,6 @@
 #include <cstdlib>
 #include <iomanip>
 #include <functional>
-#include <optional>
 
 // Localization
 #include "../../vendor/tinygettext/tinygettext.hpp"

Client/mods/deathmatch/logic/CClientModelCacheManager.cpp

@@ -38,7 +38,7 @@ class CClientModelCacheManagerImpl : public CClientModelCacheManager
     // CClientModelCacheManager interface
     virtual void DoPulse();
     virtual void OnRestreamModel(ushort usModelId);
-    virtual void SetCustomLimits(std::optional<size_t> numVehicles, std::optional<size_t> numPeds);
+    virtual void SetCustomLimits(const size_t* numVehicles, const size_t* numPeds);
 
     // CClientModelCacheManagerImpl methods
     CClientModelCacheManagerImpl();
@@ -520,7 +520,7 @@ void CClientModelCacheManagerImpl::OnRestreamModel(ushort usModelId)
     m_pCoreModelCacheManager->OnRestreamModel(usModelId);
 }
 
-void CClientModelCacheManagerImpl::SetCustomLimits(std::optional<size_t> numVehicles, std::optional<size_t> numPeds)
+void CClientModelCacheManagerImpl::SetCustomLimits(const size_t* numVehicles, const size_t* numPeds)
 {
     m_pCoreModelCacheManager->SetCustomLimits(numVehicles, numPeds);
 }

Client/mods/deathmatch/logic/CClientModelCacheManager.h

@@ -15,7 +15,7 @@ class CClientModelCacheManager
     // CClientModelCacheManager interface
     virtual void DoPulse() = 0;
     virtual void OnRestreamModel(ushort usModelId) = 0;
-    virtual void SetCustomLimits(std::optional<size_t> numVehicles, std::optional<size_t> numPeds) = 0;
+    virtual void SetCustomLimits(const size_t* numVehicles, const size_t* numPeds) = 0;
 };
 
 CClientModelCacheManager* NewClientModelCacheManager();

Client/mods/deathmatch/logic/luadefs/CLuaEngineDefs.cpp

@@ -21,7 +21,11 @@
 //! Set the CModelCacheManager limits
 //! By passing `nil`/no value the original values are restored
 void EngineStreamingSetModelCacheLimits(std::optional<size_t> numVehicles, std::optional<size_t> numPeds) {
-    g_pClientGame->GetModelCacheManager()->SetCustomLimits(numVehicles, numPeds);
+    size_t vehicleValue = numVehicles.value_or(0);
+    size_t pedValue = numPeds.value_or(0);
+    const size_t* pVehicles = numVehicles.has_value() ? &vehicleValue : nullptr;
+    const size_t* pPeds = numPeds.has_value() ? &pedValue : nullptr;
+    g_pClientGame->GetModelCacheManager()->SetCustomLimits(pVehicles, pPeds);
 }
 
 void EngineStreamingFreeUpMemory(std::uint32_t bytes)