Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social profile icons #218

Closed
erlend-sh opened this issue Oct 24, 2024 · 11 comments
Closed

Social profile icons #218

erlend-sh opened this issue Oct 24, 2024 · 11 comments
Assignees
Milestone

Comments

@erlend-sh
Copy link
Contributor

IMG_2550

A typical linkspage supports a special kind of link that doesn’t appear among the vertically listed boxes, but rather as a tiny platform-logo right underneath the avatar.

How do we add these without too many preemptive fields?

IMG_2549

I suggest we have just a single box, with an additional added for each one you fill in. Pasting a link from a common social network like Mastodon, Bluesky, LinkedIn, GitHub, Instagram etc. should automatically fill in the correct icon for it.

That way we don’t have to play favorites.

Here’s a good list of services as well as source of images: https://github.com/sethcottle/littlelink/tree/main/images/icons

@harshmangalam
Copy link
Contributor

harshmangalam commented Nov 14, 2024

@erlend-sh We have already added social media icons from link in this fix
#219

So, for what links we are going to show only icon instead of full button with text ?

@erlend-sh
Copy link
Contributor Author

‘Social Links’ is a new links section, positioned above the markdown ‘Description’ section.

The most widely used social accounts (with very recognizable logos) will usually be added here instead of the links-list further below.

@harshmangalam
Copy link
Contributor

Thanks i will show top 5 most used social media in that sections and rest in links-list

@zicklag
Copy link
Collaborator

zicklag commented Dec 19, 2024

I think this is done. Re-open if I read that wrong.

@zicklag zicklag closed this as completed Dec 19, 2024
@erlend-sh
Copy link
Contributor Author

erlend-sh commented Dec 20, 2024

‘Social Links’ is a new links section, positioned above the markdown ‘Description’ section.

do we have this? I don’t understand yet how I can add social links. We also don’t appear to display them on the pubpage.

Also, we should make people’s Weird profile link a prefilled link slot.

@zicklag
Copy link
Collaborator

zicklag commented Dec 21, 2024

Ah, I forgot about the pubpage theme, we do need to make the social links display differently there.

I don’t understand yet how I can add social links.

I thought we went in a new direction or something, since now we automatically determine social links from the URL:

recording-2024-12-20_18.54.57.mp4

And it turns into a badge at the top of the page:

image

Also, we should make people’s Weird profile link a prefilled link slot.

That's not really something the user can change, though, right, so it doesn't really need to show up anywhere but the pubpage, which we already do automatically.

It probably doesn't make sense for the Weird pubpage to link to itself?

@zicklag zicklag reopened this Dec 21, 2024
@erlend-sh
Copy link
Contributor Author

I’d rather have it show up automatically as an icon up there rather than the full link here
IMG_2623

@erlend-sh
Copy link
Contributor Author

I thought we went in a new direction or something, since now we automatically determine social links from the URL

I guess that’s good enough for now 👌

When #241 lands we will move this links wizard above the markdown box and make it exclusively for social icons.

@erlend-sh
Copy link
Contributor Author

IMG_2624

Github link is added both as social icon as well as link box, but we don’t wanna display it as the latter.

@zicklag
Copy link
Collaborator

zicklag commented Dec 21, 2024

All that sounds good. 👍

@erlend-sh
Copy link
Contributor Author

With separate social links done, to close we just need:

  • Render social icons on pubpage.
  • Add a hardcoded entry for Weird among the social links, instead of a list-link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants