This repository was archived by the owner on Jun 18, 2025. It is now read-only.
Hydra fft defaults#338
Merged
munshkr merged 2 commits intomunshkr:mainfrom Apr 5, 2025
Merged
Conversation
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While playing with the fft function over in nudel for the last few month, I've noticed that the defaults currently (
fft(1,8)) don't make much sense in most cases.I almost always change them to
fft(0,1), so I think these are better values.Sadly this change is technically compatability breaking with current flok-rooms.
I think that is fine as the impact is small-ish.
In general 0,1 has a bit bigger amplitudes, but it also incorporates all of the frequency spectrum (and not only an eights).
Changes:
indexis now 0bucketsis now 1