Skip to content
This repository was archived by the owner on Jun 18, 2025. It is now read-only.

Hydra fft defaults#338

Merged
munshkr merged 2 commits intomunshkr:mainfrom
reckter:hydra-fft-defaults
Apr 5, 2025
Merged

Hydra fft defaults#338
munshkr merged 2 commits intomunshkr:mainfrom
reckter:hydra-fft-defaults

Conversation

@reckter
Copy link
Copy Markdown
Contributor

@reckter reckter commented Mar 29, 2025

While playing with the fft function over in nudel for the last few month, I've noticed that the defaults currently (fft(1,8)) don't make much sense in most cases.

I almost always change them to fft(0,1), so I think these are better values.

Sadly this change is technically compatability breaking with current flok-rooms.
I think that is fine as the impact is small-ish.

In general 0,1 has a bit bigger amplitudes, but it also incorporates all of the frequency spectrum (and not only an eights).

Changes:

  • change defaults of fft function:
    • index is now 0
    • buckets is now 1
  • the third parameters can now also just be a string, setting the analyzer id directly.
    • this is the most used other option, and it was noisy to set it with the object each time

@munshkr munshkr merged commit c9a7712 into munshkr:main Apr 5, 2025
2 checks passed
@munshkr
Copy link
Copy Markdown
Owner

munshkr commented Apr 5, 2025

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants