Merge pull request #34570 from RomanPudashkin/crash_on_close_score_with_selected_chord_symbol_47

[4.7.5] Fix #34566: Crash when closing score with selected chord symbol

Author: RomanPudashkin

src/inspector/qml/MuseScore/Inspector/abstractinspectormodel.cpp

@@ -540,6 +540,11 @@ void AbstractInspectorModel::requestElements()
     }
 }
 
+void AbstractInspectorModel::disconnectAll()
+{
+    async_disconnectAll();
+}
+
 void AbstractInspectorModel::onCurrentNotationChanged()
 {
 }

src/inspector/qml/MuseScore/Inspector/abstractinspectormodel.h

@@ -185,6 +185,8 @@ class AbstractInspectorModel : public QObject, public muse::async::Asyncable, pu
 
     virtual void requestElements();
 
+    virtual void disconnectAll();
+
     virtual void onCurrentNotationChanged();
 
     virtual void onNotationChanged(const mu::engraving::PropertyIdSet& changedPropertyIdSet,

src/inspector/qml/MuseScore/Inspector/abstractinspectorproxymodel.cpp

@@ -91,6 +91,15 @@ void AbstractInspectorProxyModel::requestResetToDefaults()
     }
 }
 
+void AbstractInspectorProxyModel::disconnectAll()
+{
+    for (AbstractInspectorModel* model : modelList()) {
+        model->disconnectAll();
+    }
+
+    AbstractInspectorModel::disconnectAll();
+}
+
 bool AbstractInspectorProxyModel::isEmpty() const
 {
     for (const AbstractInspectorModel* model : modelList()) {
@@ -114,7 +123,10 @@ void AbstractInspectorProxyModel::setModels(const QList<AbstractInspectorModel*>
         auto oldModel = m_models.take(model->modelType());
 
         //! NOTE: may run synchronously from a model's own property-change callback;
-        //! deleting immediately would destroy "this" mid-call, so defer it
+        //! deleting immediately would destroy "this" mid-call, so defer it.
+        //! Disconnect now so it (and its submodels) doesn't react to further updates
+        //! while it awaits destruction
+        oldModel->disconnectAll();
         oldModel->deleteLater();
     }
 

src/inspector/qml/MuseScore/Inspector/abstractinspectorproxymodel.h

@@ -61,6 +61,7 @@ class AbstractInspectorProxyModel : public AbstractInspectorModel
 
     void requestElements() override;
     void requestResetToDefaults() override;
+    void disconnectAll() override;
     bool isEmpty() const override;
 
     void updateModels(const ElementKeySet& newElementKeySet);

src/inspector/qml/MuseScore/Inspector/inspectorlistmodel.cpp

@@ -285,7 +285,10 @@ void InspectorListModel::removeUnusedModels(const ElementKeySet& newElementKeySe
         m_modelList.removeAt(index);
 
         //! NOTE: may run synchronously from a model's own property-change callback;
-        //! deleting immediately would destroy "this" mid-call, so defer it
+        //! deleting immediately would destroy "this" mid-call, so defer it.
+        //! Disconnect now so it (and its submodels) doesn't react to further updates
+        //! while it awaits destruction
+        model->disconnectAll();
         model->deleteLater();
 
         endRemoveRows();