Fix #29716 adding fret diagram to harmony with parts and simplify code

We can use Score::undoChangeParent instead of FretLinkHarmony

Author: mike-spa

src/engraving/dom/edit.cpp

@@ -3980,11 +3980,7 @@ void Score::cmdDeleteSelection()
                     FretDiagram* fretDiagram = toFretDiagram(e);
                     Harmony* harmony = fretDiagram->harmony();
                     if (harmony) {
-                        for (EngravingObject* o: fretDiagram->linkList()) {
-                            FretDiagram* linkedDiagram = toFretDiagram(o);
-                            Harmony* linkedHarmony = linkedDiagram->harmony();
-                            undo(new FretLinkHarmony(linkedDiagram, linkedHarmony, true /* unlink */));
-                        }
+                        undoChangeParent(harmony, fretDiagram->segment(), track2staff(fretDiagram->track()));
                         elSelectedAfterDeletion = harmony;
                     }
                 } else if (e->isHarmony()) {
@@ -6987,21 +6983,7 @@ void Score::undoAddElement(EngravingItem* element, bool addToLinkedStaves, bool
             ne->setTrack(linkedTrack);
             ne->setParent(seg);
 
-            // make harmony child of fret diagram if possible
-            if (ne->isHarmony()) {
-                for (EngravingItem* segel : segment->annotations()) {
-                    if (segel && segel->isFretDiagram() && segel->track() == linkedTrack && !toFretDiagram(segel)->harmony()) {
-                        segel->add(ne);
-                        break;
-                    }
-                }
-            } else if (ne->isFretDiagram()) {
-                // update track of child harmony
-                FretDiagram* fd = toFretDiagram(ne);
-                if (fd->harmony()) {
-                    fd->harmony()->setTrack(linkedTrack);
-                }
-            } else if (ne->isStringTunings()) {
+            if (ne->isStringTunings()) {
                 StringTunings* stringTunings = toStringTunings(ne);
                 if (stringTunings->stringData()->isNull()) {
                     const StringData* stringData = stringTunings->part()->stringData(tick, staff->idx());

src/engraving/dom/undo.cpp

@@ -3557,31 +3557,6 @@ void ChangeTieJumpPointActive::flip(EditData*)
     m_active = oldActive;
 }
 
-FretLinkHarmony::FretLinkHarmony(FretDiagram* diagram, Harmony* harmony, bool unlink)
-{
-    m_fretDiagram = diagram;
-    m_harmony = harmony;
-    m_unlink = unlink;
-}
-
-void FretLinkHarmony::undo(EditData*)
-{
-    if (m_unlink) {
-        m_fretDiagram->linkHarmony(m_harmony);
-    } else {
-        m_fretDiagram->unlinkHarmony();
-    }
-}
-
-void FretLinkHarmony::redo(EditData*)
-{
-    if (m_unlink) {
-        m_fretDiagram->unlinkHarmony();
-    } else {
-        m_fretDiagram->linkHarmony(m_harmony);
-    }
-}
-
 RemoveFretDiagramFromFretBox::RemoveFretDiagramFromFretBox(FretDiagram* f)
     : m_fretDiagram(f)
 {

src/engraving/dom/undo.h

@@ -1806,25 +1806,6 @@ class FretClear : public UndoCommand
     UNDO_CHANGED_OBJECTS({ diagram })
 };
 
-class FretLinkHarmony : public UndoCommand
-{
-    OBJECT_ALLOCATOR(engraving, FretLinkHarmony)
-
-    FretDiagram* m_fretDiagram = nullptr;
-    Harmony* m_harmony = nullptr;
-    bool m_unlink = false;
-
-    void undo(EditData*) override;
-    void redo(EditData*) override;
-
-public:
-    FretLinkHarmony(FretDiagram*, Harmony*, bool unlink = false);
-
-    UNDO_TYPE(CommandType::FretLinkHarmony)
-    UNDO_NAME("FretLinkHarmony")
-    UNDO_CHANGED_OBJECTS({ m_fretDiagram })
-};
-
 class RemoveFretDiagramFromFretBox : public UndoCommand
 {
     OBJECT_ALLOCATOR(engraving, RemoveFretDiagramFromFretBox)

src/notation/internal/notationinteraction.cpp

@@ -7856,11 +7856,11 @@ void NotationInteraction::addFretboardDiagram()
         diagram->setTrack(element->track());
 
         Harmony* harmony = toHarmony(element);
-
         diagram->updateDiagram(harmony->harmonyName());
-        score->undo(new FretLinkHarmony(diagram, harmony));
 
+        diagram->setParent(harmony->parent());
         score->undoAddElement(diagram);
+        score->undoChangeParent(harmony, diagram, track2staff(element->track()));
 
         lastAddedDiagram = diagram;
     }