Skip to content

리뷰 관련 수정사항 수정 #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JTH-00 merged 3 commits into from
Jul 10, 2025
Merged

리뷰 관련 수정사항 수정 #146

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
765663a
fix (JTH-00) : 모니터 비율 및 화면 배율 축소 후 스크롤 다운 시 인식하지 못해 리뷰 무한 스크롤이 안되는 부분 수정
JTH-00 Jul 10, 2025
a5a1c8b
fix (JTH-00) : 리뷰를 스크롤 다운하지 않을 경우 총 리뷰수가 10개로 보이던 부분 수정
JTH-00 Jul 10, 2025
21f1845
chore (JTH-00) : 빌드에러 수정
JTH-00 Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/pages/detail/ui/ReviewList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import styled from '@emotion/styled';
import { useInfiniteQuery } from '@tanstack/react-query';
import { startTransition, useCallback, useEffect, useState } from 'react';
import { startTransition, useCallback, useEffect, useRef, useState } from 'react';
import { useParams } from 'react-router-dom';

import { ANCHOR_REVIEW } from 'pages/detail/config/anchor';
Expand Down Expand Up @@ -84,6 +84,24 @@
return () => window.removeEventListener('scroll', handleScroll);
}, [handleScroll]);

const loaderRef = useRef(null);

useEffect(() => {
if (!hasNextPage || isFetchingNextPage) return;
const observer = new window.IntersectionObserver(
(entries) => {
if (entries[0].isIntersecting) {
void fetchNextPage();
}
},
{ rootMargin: '200px' } // 미리 로드
);
if (loaderRef.current) observer.observe(loaderRef.current);
return () => {
if (loaderRef.current) observer.unobserve(loaderRef.current);

Check warning on line 101 in src/pages/detail/ui/ReviewList.tsx

View workflow job for this annotation

GitHub Actions / run lint, build 

The ref value 'loaderRef.current' will likely have changed by the time this effect cleanup function runs. If this ref points to a node rendered by React, copy 'loaderRef.current' to a variable inside the effect, and use that variable in the cleanup function
};
}, [hasNextPage, isFetchingNextPage, fetchNextPage]);

if (isLoading) {
return (
<Section>
Expand All @@ -97,7 +115,7 @@
return (
<Section>
<SectionTitle>
별점 및 리뷰({allReviews.length})
별점 및 리뷰({data?.pages[0].data.totalElements})
<Filter
placeholder={selectedFilter.label}
options={REVIEW_FILTER_OPTIONS}
Expand All @@ -107,6 +125,7 @@
</SectionTitle>
<ReplyList id={ANCHOR_REVIEW}>
<Reply comments={allReviews} onDeleteReply={handleDeleteReply} onModifyReply={handleModifyReply} />
<div ref={loaderRef} />
{isFetchingNextPage && (
<LoadingContainer>
<Skeleton />
Expand Down
Loading