Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when serializing data from module SMS: Circular reference detected #443

Closed
Shellcat-Zero opened this issue Dec 28, 2023 · 4 comments · Fixed by #444
Closed

Error when serializing data from module SMS: Circular reference detected #443

Shellcat-Zero opened this issue Dec 28, 2023 · 4 comments · Fixed by #444
Labels
bug Something isn't working ios

Comments

@Shellcat-Zero
Copy link

When running:
mvt-ios check-backup --output ./check_backup decrypted_backup/

I am getting the error:

14:27:50 ERROR    [mvt.ios.modules.mixed.sms] Error when serializing data from module SMS: Circular reference detected                                                                                                                                                         
                  Traceback (most recent call last):                                                                                                                                                                                                                           
                    File "/home/user/miniconda3/lib/python3.11/site-packages/mvt/common/module.py", line 217, in run_module                                                                                                                                                      
                      module.to_timeline()                                                                                                                                                                                                                                     
                    File "/home/user/miniconda3/lib/python3.11/site-packages/mvt/common/module.py", line 155, in to_timeline                                                                                                                                                     
                      self.timeline = self._deduplicate_timeline(self.timeline)                                                                                                                                                                                                
                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                                                                                
                    File "/home/user/miniconda3/lib/python3.11/site-packages/mvt/common/module.py", line 133, in _deduplicate_timeline                                                                                                                                           
                      timeline_set.add(json.dumps(record, sort_keys=True))                                                                                                                                                                                                     
                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                                                                                      
                    File "/home/user/miniconda3/lib/python3.11/json/__init__.py", line 238, in dumps                                                                                                                                                                             
                      **kw).encode(obj)                                                                                                                                                                                                                                        
                            ^^^^^^^^^^^                                                                                                                                                                                                                                        
                    File "/home/user/miniconda3/lib/python3.11/json/encoder.py", line 200, in encode                                                                                                                                                                             
                      chunks = self.iterencode(o, _one_shot=True)                                                                                                                                                                                                              
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                                                                                                                                                                                                              
                    File "/home/user/miniconda3/lib/python3.11/json/encoder.py", line 258, in iterencode                                                                                                                                                                         
                      return _iterencode(o, 0)                                                                                                                                                                                                                                 
                             ^^^^^^^^^^^^^^^^^                                                                                                                                                                                                                                 
                  ValueError: Circular reference detected

I'm running python 3.11.5 and MVT==2.4.5 after cloning the repo. I encountered this error after pulling in the uri=True fix from #434.

@roaree
Copy link
Contributor

roaree commented Jan 3, 2024

@Shellcat-Zero Can you confirm if the same error occurs with mvt==2.4.3 from PyPI? It looks like another bug, but I would be quite surprised if the change introduced in #442 caused this.

@roaree roaree added bug Something isn't working ios labels Jan 3, 2024
@roaree
Copy link
Contributor

roaree commented Jan 3, 2024

SMS module had recent changes in #438 that are not yet in a PyPI release but are in main - seems related.

@roaree
Copy link
Contributor

roaree commented Jan 3, 2024

Thanks for the report! Feel free to reopen if the fix in #444 didn't fix this bug

@Shellcat-Zero
Copy link
Author

@roaree 2.4.3 from PyPI does not produce the error. After pulling the latest commits, it appears 2.5.0 works now without the error. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ios
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants