Suppress DCP log spew and manifest publishing lifetime logs. (dotnet#642)

* Suppress DCP log spew and manifest publishing lifetime logs.

Author: mitchdenny

src/Aspire.Hosting/Dcp/DcpHostService.cs

@@ -350,7 +350,7 @@ private async Task LogSocketOutputAsync(Socket socket)
             {
                 // loggerFactory.CreateLogger internally caches, but we may as well cache the logger as well as the string
                 // for the lifetime of this socket
-                loggerCache[hashValue] = logger = _loggerFactory.CreateLogger(Encoding.UTF8.GetString(category));
+                loggerCache[hashValue] = logger = _loggerFactory.CreateLogger($"Aspire.Hosting.Dcp.{Encoding.UTF8.GetString(category)}");
             }
 
             return (logger, logLevel, Encoding.UTF8.GetString(message));

src/Aspire.Hosting/DistributedApplication.cs

@@ -4,8 +4,11 @@
 using System.Diagnostics;
 using Aspire.Hosting.ApplicationModel;
 using Aspire.Hosting.Lifecycle;
+using Aspire.Hosting.Publishing;
+using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Hosting;
+using Microsoft.Extensions.Options;
 
 namespace Aspire.Hosting;
 
@@ -65,8 +68,27 @@ public async Task StopAsync(CancellationToken cancellationToken = default)
         await _host.StopAsync(cancellationToken).ConfigureAwait(false);
     }
 
+    private void SuppressLifetimeLogsDuringManifestPublishing()
+    {
+        var config = (IConfigurationRoot)_host.Services.GetRequiredService<IConfiguration>();
+        var options = _host.Services.GetRequiredService<IOptions<PublishingOptions>>();
+
+        if (options.Value?.Publisher != "manifest")
+        {
+            // If we aren't doing manifest pubilshing we want the logs
+            // to be produced as normal.
+            return;
+        }
+
+        var hostingLifetimeLoggingLevelSection = config.GetSection("Logging:LogLevel:Microsoft.Hosting.Lifetime");
+        hostingLifetimeLoggingLevelSection.Value = "Warning";
+
+        config.Reload();
+    }
+
     public async Task RunAsync(CancellationToken cancellationToken = default)
     {
+        SuppressLifetimeLogsDuringManifestPublishing();
         await ExecuteBeforeStartHooksAsync(cancellationToken).ConfigureAwait(false);
         await _host.RunAsync(cancellationToken).ConfigureAwait(false);
     }

src/Aspire.Hosting/Publishing/ManifestPublisher.cs

@@ -4,12 +4,14 @@
 using System.Text.Json;
 using Aspire.Hosting.ApplicationModel;
 using Microsoft.Extensions.Hosting;
+using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
 
 namespace Aspire.Hosting.Publishing;
 
-public class ManifestPublisher(IOptions<PublishingOptions> options, IHostApplicationLifetime lifetime) : IDistributedApplicationPublisher
+public class ManifestPublisher(ILogger<ManifestPublisher> logger, IOptions<PublishingOptions> options, IHostApplicationLifetime lifetime) : IDistributedApplicationPublisher
 {
+    private readonly ILogger<ManifestPublisher> _logger = logger;
     private readonly IOptions<PublishingOptions> _options = options;
     private readonly IHostApplicationLifetime _lifetime = lifetime;
 
@@ -34,6 +36,9 @@ protected virtual async Task PublishInternalAsync(DistributedApplicationModel mo
         using var jsonWriter = JsonWriter ?? new Utf8JsonWriter(stream, new JsonWriterOptions { Indented = true });
 
         await WriteManifestAsync(model, jsonWriter, cancellationToken).ConfigureAwait(false);
+
+        var fullyQualifiedPath = Path.GetFullPath(_options.Value.OutputPath);
+        _logger.LogInformation("Published manifest to: {manifestPath}", fullyQualifiedPath);
     }
 
     protected async Task WriteManifestAsync(DistributedApplicationModel model, Utf8JsonWriter jsonWriter, CancellationToken cancellationToken)

src/Aspire.ProjectTemplates/templates/aspire-empty/AspireApplication-1.AppHost/appsettings.json

@@ -2,7 +2,8 @@
   "Logging": {
     "LogLevel": {
       "Default": "Information",
-      "Microsoft.AspNetCore": "Warning"
+      "Microsoft.AspNetCore": "Warning",
+      "Aspire.Hosting.Dcp": "Warning"
     }
   }
 }

src/Aspire.ProjectTemplates/templates/aspire-starter/AspireStarterApplication-1.AppHost/appsettings.json

@@ -2,7 +2,8 @@
   "Logging": {
     "LogLevel": {
       "Default": "Information",
-      "Microsoft.AspNetCore": "Warning"
+      "Microsoft.AspNetCore": "Warning",
+      "Aspire.Hosting.Dcp": "Warning"
     }
   }
 }

tests/Aspire.Hosting.Tests/Helpers/JsonDocumentManifestPublisher.cs

@@ -5,11 +5,12 @@
 using Aspire.Hosting.Publishing;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Hosting;
+using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
 
 namespace Aspire.Hosting.Tests.Helpers;
 
-internal sealed class JsonDocumentManifestPublisher(IOptions<PublishingOptions> options, IHostApplicationLifetime lifetime) : ManifestPublisher(options, lifetime)
+internal sealed class JsonDocumentManifestPublisher(ILogger<ManifestPublisher> logger, IOptions<PublishingOptions> options, IHostApplicationLifetime lifetime) : ManifestPublisher(logger, options, lifetime)
 {
     protected override async Task PublishInternalAsync(DistributedApplicationModel model, CancellationToken cancellationToken)
     {