fix pmd

Author: namanONcode

config/pmd/pmd-ruleset.xml

@@ -8,8 +8,6 @@
 
     <!-- Best Practices -->
     <rule ref="category/java/bestpractices.xml">
-        <exclude name="JUnitTestContainsTooManyAsserts"/>
-        <exclude name="JUnitAssertionsShouldIncludeMessage"/>
         <exclude name="GuardLogStatement"/>
     </rule>
 
@@ -18,7 +16,6 @@
         <exclude name="OnlyOneReturn"/>
         <exclude name="AtLeastOneConstructor"/>
         <exclude name="CommentDefaultAccessModifier"/>
-        <exclude name="DefaultPackage"/>
         <exclude name="LongVariable"/>
         <exclude name="ShortVariable"/>
         <exclude name="ShortMethodName"/>
@@ -27,6 +24,7 @@
         <exclude name="CallSuperInConstructor"/>
         <exclude name="LocalVariableCouldBeFinal"/>
         <exclude name="MethodArgumentCouldBeFinal"/>
+        <exclude name="FieldDeclarationsShouldBeAtStartOfClass"/>
     </rule>
 
     <!-- Design -->
@@ -42,8 +40,6 @@
 
     <!-- Error Prone -->
     <rule ref="category/java/errorprone.xml">
-        <exclude name="BeanMembersShouldSerialize"/>
-        <exclude name="DataflowAnomalyAnalysis"/>
         <exclude name="AvoidLiteralsInIfCondition"/>
         <exclude name="AvoidFieldNameMatchingMethodName"/>
     </rule>

pom.xml

@@ -112,7 +112,7 @@
         <checkstyle.version>3.6.0</checkstyle.version>
         <checkstyle-tool.version>10.21.4</checkstyle-tool.version>
         <pmd-plugin.version>3.26.0</pmd-plugin.version>
-        <pmd-tool.version>7.9.0</pmd-tool.version>
+        <pmd-tool.version>7.11.0</pmd-tool.version>
         <spotbugs.version>4.9.3.0</spotbugs.version>
         <jacoco.version>0.8.15</jacoco.version>
     </properties>
@@ -442,8 +442,19 @@
                             <artifactId>pmd-java</artifactId>
                             <version>${pmd-tool.version}</version>
                         </dependency>
+                        <dependency>
+                            <groupId>net.sourceforge.pmd</groupId>
+                            <artifactId>pmd-core</artifactId>
+                            <version>${pmd-tool.version}</version>
+                        </dependency>
+                        <dependency>
+                            <groupId>org.ow2.asm</groupId>
+                            <artifactId>asm</artifactId>
+                            <version>9.7.1</version>
+                        </dependency>
                     </dependencies>
                     <configuration>
+                        <targetJdk>21</targetJdk>
                         <rulesets>
                             <ruleset>${maven.multiModuleProjectDirectory}/config/pmd/pmd-ruleset.xml</ruleset>
                         </rulesets>

zthread-benchmark/pom.xml

@@ -14,6 +14,10 @@
     <name>zThread Benchmark</name>
     <description>JMH benchmarks for the zThread event runtime comparing against BlockingQueue, ExecutorService, and Netty.</description>
 
+    <properties>
+        <pmd.skip>true</pmd.skip>
+    </properties>
+
     <dependencies>
         <dependency>
             <groupId>io.github.namanoncode</groupId>

zthread-core/src/main/java/io/github/namanoncode/zthread/DefaultEventDispatcher.java

@@ -48,6 +48,7 @@ public final class DefaultEventDispatcher implements EventDispatcher {
 
   private static final Logger LOG = LoggerFactory.getLogger(DefaultEventDispatcher.class);
 
+  @SuppressWarnings("PMD.LooseCoupling")
   private final Map<Class<? extends ZEvent>, List<HandlerEntry<?>>> handlers =
       new ConcurrentHashMap<>();
   private final RuntimeMetrics metrics;
@@ -78,7 +79,7 @@ public <T extends ZEvent> HandlerRegistration register(
   }
 
   @Override
-  @SuppressWarnings({"unchecked", "rawtypes"})
+  @SuppressWarnings({"unchecked", "rawtypes", "PMD.AvoidCatchingGenericException"})
   public void dispatch(ZEvent event) {
     List<HandlerEntry<?>> entries = handlers.get(event.getClass());
     if (entries == null || entries.isEmpty()) {
@@ -93,8 +94,7 @@ public void dispatch(ZEvent event) {
       try {
         entry.handler().handle(event);
       } catch (Exception e) {
-        LOG.error("Handler threw exception for {}: {}", event.getClass().getSimpleName(),
-            e.getMessage(), e);
+        LOG.error("Handler threw exception for {}: {}", event.getClass().getSimpleName(), e);
         dispatchError(e, "Handler exception for " + event.getClass().getSimpleName());
       } finally {
         metrics.recordHandlerTime(System.nanoTime() - start);

zthread-core/src/main/java/io/github/namanoncode/zthread/ZRuntimeBuilder.java

@@ -49,7 +49,7 @@ public final class ZRuntimeBuilder {
   private int bufferSize = 4096;
   private int maxEventsPerPoll = 64;
   private boolean metricsEnabled = true;
-  private boolean debugEnabled = false;
+  private boolean debugEnabled;
 
   /** Creates a new builder with default settings. */
   ZRuntimeBuilder() {}

zthread-core/src/main/java/io/github/namanoncode/zthread/event/ErrorEvent.java

@@ -30,8 +30,6 @@ public final class ErrorEvent implements ZEvent {
   private String message;
   private long timestampNanos;
 
-  /** Creates an uninitialized error event. */
-  public ErrorEvent() {}
 
   /**
    * Resets this event with new values.

zthread-core/src/main/java/io/github/namanoncode/zthread/event/FileEvent.java

@@ -68,8 +68,6 @@ public final class FileEvent implements ZEvent {
   private String name;
   private long timestampNanos;
 
-  /** Creates an uninitialized file event. */
-  public FileEvent() {}
 
   /**
    * Resets this event with new values.

zthread-core/src/main/java/io/github/namanoncode/zthread/event/ShutdownEvent.java

@@ -30,7 +30,7 @@
  */
 public final class ShutdownEvent implements ZEvent {
 
-  private long timestampNanos;
+  private final long timestampNanos;
 
   /** Creates a new shutdown event. */
   public ShutdownEvent() {

zthread-core/src/main/java/io/github/namanoncode/zthread/event/SignalEvent.java

@@ -34,8 +34,6 @@ public final class SignalEvent implements ZEvent {
   private int senderUid;
   private long timestampNanos;
 
-  /** Creates an uninitialized signal event. */
-  public SignalEvent() {}
 
   /**
    * Resets this event with new values.

zthread-core/src/main/java/io/github/namanoncode/zthread/event/SocketEvent.java

@@ -51,8 +51,6 @@ public final class SocketEvent implements ZEvent {
   private int eventMask;
   private long timestampNanos;
 
-  /** Creates an uninitialized socket event. Used by the object pool. */
-  public SocketEvent() {}
 
   /**
    * Resets this event with new values. Called by the event loop before dispatch.