Fix unit tests, add joinParts utility

Author: kydecker

src/pdfs/ri/pc8.1-change-of-name/index.ts

@@ -1,6 +1,7 @@
 import { formatBirthplaceCountryOrState } from "../../../utils/formatBirthplaceCountryOrState";
 import { formatDateMMDDYYYY } from "../../../utils/formatDateMMDDYYYY";
 import { joinNames } from "../../../utils/joinNames";
+import { joinParts } from "../../../utils/joinParts";
 import { definePdf } from "../../utils/definePdf";
 import pdf from "./pc8.1-change-of-name.pdf";
 import type { PdfFieldName } from "./schema";
@@ -24,29 +25,25 @@ export default definePdf<PdfFieldName>({
       residenceZipCode: data.residenceZipCode,
       phoneNumber: data.phoneNumber,
       mailingStreetAddress: data.mailingStreetAddress,
-      mailingCityStateAndZip: [
+      mailingCityStateAndZip: joinParts(
         data.mailingCity,
         data.mailingState,
         data.mailingZipCode,
-      ]
-        .filter(Boolean)
-        .join(", "),
+      ),
       email: data.email,
       nameOnOriginalBirthRecord: joinNames(
         data.oldFirstName,
         data.oldMiddleName,
         data.oldLastName,
       ),
       dateOfBirth: formatDateMMDDYYYY(data.dateOfBirth),
-      placeOfBirth: [
+      placeOfBirth: joinParts(
         data.birthplaceCity,
         formatBirthplaceCountryOrState(
           data.birthplaceCountry,
           data.birthplaceState,
         ),
-      ]
-        .filter(Boolean)
-        .join(", "),
+      ),
       mothersMaidenName: joinNames(
         data.mothersFirstName,
         data.mothersMiddleName,

src/utils/__tests__/joinParts.test.ts

@@ -0,0 +1,24 @@
+import { describe, expect, it } from "vitest";
+import { joinParts } from "../joinParts";
+
+describe("joinParts", () => {
+  it("joins all parts with a comma", () => {
+    expect(joinParts("Providence", "RI", "02903")).toBe("Providence, RI, 02903");
+  });
+
+  it("filters out undefined values", () => {
+    expect(joinParts("Providence", undefined, "02903")).toBe("Providence, 02903");
+  });
+
+  it("returns undefined when all values are undefined", () => {
+    expect(joinParts(undefined, undefined, undefined)).toBeUndefined();
+  });
+
+  it("returns undefined when called with no arguments", () => {
+    expect(joinParts()).toBeUndefined();
+  });
+
+  it("returns a single value without a trailing comma", () => {
+    expect(joinParts(undefined, "RI", undefined)).toBe("RI");
+  });
+});

src/utils/joinParts.ts

@@ -0,0 +1,4 @@
+export const joinParts = (...parts: (string | undefined)[]): string | undefined => {
+  const result = parts.filter(Boolean).join(", ");
+  return result || undefined;
+};