Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding BaseImagePlaceholder to BlockIframe #129

Closed
stephiescastle opened this issue Jan 31, 2022 · 0 comments · Fixed by #161
Closed

Consider adding BaseImagePlaceholder to BlockIframe #129

stephiescastle opened this issue Jan 31, 2022 · 0 comments · Fixed by #161
Assignees
@stephiescastle
Labels
enhancement New feature or request feature parity Work needed to maintain consistency between our implementations of Explorer 1

Comments

@stephiescastle
Copy link
Member

This was an improvement added to the vue component in www-frontend in where BaseImagePlaceholder is used as a wrapper. If no height is set, the iframe embed will default to a responsive 16:9 aspect ratio. If a height is set, the aspect ratio will be overridden.

https://github.com/nasa-jpl/www-frontend/commit/a398623aac611205a7db92cb885453a081cbcc0d#diff-ff86cff448f808a6cadd228462bda9138c9f8a4ec00755109ebc16b7750c89f1

The current implementation in Explorer requires a set height and is not responsive.
@stephiescastle stephiescastle added enhancement New feature or request feature parity Work needed to maintain consistency between our implementations of Explorer 1 labels Feb 1, 2022
@stephiescastle stephiescastle self-assigned this Feb 1, 2022
@stephiescastle stephiescastle mentioned this issue Feb 19, 2022
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephiescastle stephiescastle

Labels
enhancement New feature or request feature parity Work needed to maintain consistency between our implementations of Explorer 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding responsiveness to BlockIframeEmbed nasa-jpl/explorer-1
1 participant
@stephiescastle