Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade @tailwindcss/forms #201

Closed
stephiescastle opened this issue Apr 1, 2022 · 7 comments
Closed

Downgrade @tailwindcss/forms #201

stephiescastle opened this issue Apr 1, 2022 · 7 comments
Labels
maintenance The meta work of maintaining the project
Milestone

Comments

@stephiescastle
Copy link
Member

stephiescastle commented Apr 1, 2022

Description

We somehow missed this warning when updating @tailwindcss/forms:

npm WARN @tailwindcss/[email protected] requires a peer of tailwindcss@>=3.0.0 || >= 3.0.0-alpha.1 but none is installed. You must install peer dependencies yourself.

We should determine if using version 0.5.0 negatively impacts our build. If so, then downgrade to the latest version that doesn't require TailwindCSS 3.

@stephiescastle stephiescastle added this to the Release 1.1.1 milestone Apr 1, 2022
@Scotchester
Copy link
Member

Hmm… but we don't see any negative effects?

@stephiescastle
Copy link
Member Author

Not that I could tell!

@Scotchester
Copy link
Member

Do we really need to downgrade, then? Could be that the requirement only applies to parts of Tailwind Forms that we're not using?

@stephiescastle
Copy link
Member Author

Do we really need to downgrade, then? Could be that the requirement only applies to parts of Tailwind Forms that we're not using?

It's possible. We can check that when investigating the issue. I've updated the description to reflect that.

@stephiescastle stephiescastle added the maintenance The meta work of maintaining the project label Apr 1, 2022
@stephiescastle
Copy link
Member Author

According to the release notes, we should be on version 0.3.4. Version 0.4 and later are noted as "incompatible" with Tailwind 2, but I still haven't determined exactly what's affected. https://github.com/tailwindlabs/tailwindcss-forms/releases

@stephiescastle
Copy link
Member Author

stephiescastle commented Apr 6, 2022

I looked into this a bit more, and the part that's affected is the default colors used for form inputs, which we we're overriding anyway. However, if a user creates form elements without the CSS classes as documented in our templates, they will see these default colors. Effectively, in the CSS, the latest version of @tailwindcss/forms changes the border color of form elements from #6b7280 to #71717a, which is pretty indistinguishable to me.

So, in short, I think it's okay to leave as-is.

@Scotchester
Copy link
Member

Awesome, thanks for checking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance The meta work of maintaining the project
Projects
None yet
Development

No branches or pull requests

2 participants