Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework _BlockTable.scss to allow for a la carte imports in Vue.js #203

Closed
stephiescastle opened this issue Apr 1, 2022 · 0 comments
Closed

Comments

@stephiescastle
Copy link
Member

stephiescastle commented Apr 1, 2022

Description

  1. Currently, _BlockTable.scss uses the following, which require additional scss dependencies:
  • @extend .BlockText which requires importing _BlockText.scss to the Vue.js component as well
  • @apply ... text-subtitle ... which requires importing _typography.scss to the Vue.js component

I would prefer to eliminate the need for these workarounds and handle the imports locally in _BlockTable.scss (in some way that doesn't duplicate class definitions) or for .text-subtitle, to apply the equivalent tailwindcss classes.

Here's a relevant discussion in www-frontend: https://github.com/nasa-jpl/www-frontend/pull/1346#discussion_r842164357

  1. Additionally, since styles are declared for all of the table markup elements, can we eliminate all of the inline classes in the template? Right now the CSS styles for .BlockTable are overriding the inline classes.
@stephiescastle stephiescastle changed the title Rework _BlockTable.scss to allow for a la carte imports in Vue.js or document the workaround Rework _BlockTable.scss to allow for a la carte imports in Vue.js Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant