Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise type hierarchy #274

Closed
Scotchester opened this issue Jul 22, 2022 · 2 comments · Fixed by #313
Closed

Revise type hierarchy #274

Scotchester opened this issue Jul 22, 2022 · 2 comments · Fixed by #313
Assignees
Labels
enhancement New feature or request feature request Request to add a new component or other feature

Comments

@Scotchester
Copy link
Member

Describe the problem to be solved

The current heading scale in our design system should be revised to be smaller overall, so that we can make proper use of the full scale without faking the sizes down.

Background:

  • The JPL external website has long supported only one semantic heading level, H2, but those headings are all presented as our "Heading H5" style.
  • Similarly, H1s are styled as H2s.
  • On WCP, all heading levels are styled as one level below (H5s are not available).
  • On WWW, we've now implemented the option to choose other semantic heading levels in order to support the content needs of future press kits. When trying to use these with the heading scale as designed, it results in some headings that feel too large for the length of the content. One h3 in the sample content even gets to five lines!
    Sample press kit content showing an h2, paragraph, h3, and another paragraph

Our specific history aside, a design system's web type hierarchy should be designed such that a page can have all possible heading levels on it, all at a comfortable size, and all feeling distinct enough from each other. That is the driving principle behind this issue, in my opinion.

Suggested solution

One potential approach that we discussed yesterday would be to start from the bottom and work up: Looking at the body text (our WWW and WCP default of text-body-lg (22px), specifically), what is the smallest possible H5 that would feel appreciably distinct from the body copy? (The answer to that may still be the current H5 size, 24px.) Then, moving up to H4, what is the smallest possible H4 that would feel different enough from the H5? And so on up the hierarchy.

The resulting scale should, in particular, have an H2 style that the JPL external website team is comfortable changing all of their StreamField headings (currently styled as H5s) to.

Open questions

  • Should we add H6 to the scale?
  • Should we not add H6 and also remove H5 from the scale, limiting ourselves to just H2, H3, and H4 within body content?
  • Should we consider other style changes besides just size (e.g., weight), which might make it easier to make headings close in size more distinct from each other?
@Scotchester Scotchester added enhancement New feature or request feature request Request to add a new component or other feature labels Jul 22, 2022
@Scotchester
Copy link
Member Author

Reference chart of our current type sizes across all breakpoints:

https://docs.google.com/spreadsheets/d/1Vzb7Jg5X6-_nH5KoGEli1uw__ZMQsMMYbNAQ-Iz7fmc/edit

(Should open to a chart of pixel values; chart of rem values is available on the second tab.)

@Scotchester
Copy link
Member Author

Noting for the record the modular scale devised by @gekim84 after extensive research and testing:

Table of values for new type scale

Not pictured: no changes to Subtitled or body type sizes under Body Large.

Scotchester added a commit that referenced this issue Oct 31, 2022
Revises all heading and body sizes based on @gekim84's research that led to the creation of a modular scale.

Closes #274
@Scotchester Scotchester mentioned this issue Oct 31, 2022
17 tasks
Scotchester added a commit that referenced this issue Nov 8, 2022
Revises all heading and body sizes based on @gekim84's research that led to the creation of a modular scale.

Closes #274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request Request to add a new component or other feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants