Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discrepancies in how headings are rendered between www and edu components #501

Closed
stephiescastle opened this issue Jul 18, 2024 · 0 comments · Fixed by #504
Closed

Discrepancies in how headings are rendered between www and edu components #501

stephiescastle opened this issue Jul 18, 2024 · 0 comments · Fixed by #504
Assignees
@stephiescastle
Labels
bug Something isn't working

Comments

@stephiescastle
Copy link
Member

The cause is probably related to the new Explorer-1 BlockHeading deviating from www-frontend’s by passing a size param to BaseHeading.

Compare heading sizes on news pages between www and edu, and compare to production.
https://www-development.jpl.nasa.gov/edu/news/back-to-school-with-jpl
@stephiescastle stephiescastle added the bug Something isn't working label Jul 18, 2024
@stephiescastle stephiescastle self-assigned this Jul 18, 2024
@stephiescastle stephiescastle mentioned this issue Jul 18, 2024
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephiescastle stephiescastle

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove default size from BaseHeading nasa-jpl/explorer-1
1 participant
@stephiescastle