Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EDU Explainer Article and Header/Footer alignment #555

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Aug 20, 2024

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Address feedback in https://github.com/nasa-jpl/www/issues/364
Fixes https://github.com/nasa-jpl/www/issues/390
Fixes #551

Tweaks to various blocks:

  • BlockTeaser: fixes link
  • BlockGist: fixes iframe height and caption styles
  • BlockCardGrid: fixes mobile width
  • EduExplainerArticlePage: removes summary, adds topper
  • Tweaks alignment in TheFooter and NavHeader

Instructions to test

  1. make vue-storybook
  2. view relevant stories

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@github-actions github-actions bot added the bug Something isn't working label Aug 20, 2024
@stephiescastle stephiescastle added the patch Contains bug fixes or maintenance work label Aug 20, 2024
@jamesray
Copy link
Member

good tweaks, thanks again!

@jamesray jamesray closed this Aug 20, 2024
@jamesray jamesray reopened this Aug 20, 2024
@stephiescastle stephiescastle changed the title fix: EDU Explainer Article fix: EDU Explainer Article and Header/Footer alignment Aug 20, 2024
@stephiescastle stephiescastle merged commit e64ea88 into main Aug 20, 2024
3 checks passed
@stephiescastle stephiescastle deleted the fix/364-explainer-article-fixes branch August 20, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Contains bug fixes or maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BlockGist caption styles
2 participants