Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ArticleCarouselItem and TopicsCarouselItem to include compact versions, headingLevel prop, and improved label #58

Closed
3 tasks
stephiescastle opened this issue Nov 3, 2021 · 1 comment · Fixed by #173
Closed
3 tasks

Update ArticleCarouselItem and TopicsCarouselItem to include compact versions, headingLevel prop, and improved label #58

stephiescastle opened this issue Nov 3, 2021 · 1 comment · Fixed by #173
Assignees
@stephiescastle
Labels
enhancement New feature or request feature parity Work needed to maintain consistency between our implementations of Explorer 1

Comments

@stephiescastle
Copy link
Member

stephiescastle commented Nov 3, 2021 •
edited
Loading

This PR on www-frontend introduces a couple more styles for ArticleCarouselItem and TopicsCarouselItem. We should also show these variants in storybook. This change does not affect scss files. The compact style is achieved by conditionally applying inline classes.

Tasks

  • add compact style for ArticleCarouselItem and TopicsCarouselItem
  • add options for headingLevel to ArticleCarouselItem and TopicsCarouselItem
  • add divide-x and date styling
@stephiescastle
Copy link
Member Author

stephiescastle commented Nov 23, 2021 •
edited
Loading

We should also update both components to match the divide-x and date styling added in this PR: https://github.com/nasa-jpl/www-frontend/pull/1208

@stephiescastle stephiescastle changed the title Update ArticleCarouselItem and TopicsCarouselItem to include compact versions and headingLevel options Update ArticleCarouselItem and TopicsCarouselItem to include compact versions, headingLevel prop, and improved label Nov 23, 2021
@stephiescastle stephiescastle added enhancement New feature or request feature parity Work needed to maintain consistency between our implementations of Explorer 1 labels Feb 1, 2022
@stephiescastle stephiescastle self-assigned this Feb 1, 2022
@stephiescastle stephiescastle mentioned this issue Mar 8, 2022
Merged
17 tasks
@stephiescastle stephiescastle mentioned this issue Mar 15, 2022
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephiescastle stephiescastle

Labels
enhancement New feature or request feature parity Work needed to maintain consistency between our implementations of Explorer 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improvements to BlockLinkCard and BlockLinkTile nasa-jpl/explorer-1
1 participant
@stephiescastle