Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to BlockLinkCard and BlockLinkTile #173

Merged

Conversation

stephiescastle
Copy link
Member

@stephiescastle stephiescastle commented Mar 15, 2022

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

Closes #58. Adds the following features to BlockLinkCard and BlockLinkTile templates and stories:

  • compact styles (boolean)
  • headingLevel
  • secondaryLabel

Also restores the hover effect on the image in BlockLinkCard, which was missing!

Migration / Release notes

Improvements have been made to BlockLinkCard and BlockLinkTile, including compact styles, and styles for a secondary label. Update your HTML templates as needed.

Instructions to test

  1. npm run storybook
  2. Check the BlockLinkCard and BlockLinkTile stories to try out the new features.

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle stephiescastle added enhancement New feature or request storybook This issue relates to Storybook.js minor Contains new features or enhancements labels Mar 15, 2022
Copy link
Member

@Scotchester Scotchester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, but is it expected that on BlockLinkTile, turning on "Compact" mode actually makes it taller? (Because of the switch to a 1:1 aspect ratio.)

@stephiescastle
Copy link
Member Author

I think this is good, but is it expected that on BlockLinkTile, turning on "Compact" mode actually makes it taller? (Because of the switch to a 1:1 aspect ratio.)

Yeah, I wasn't quite sure how to handle this. Compact is a bit of a misnomer, but the 1:1 ratio is intentional.

@stephiescastle stephiescastle enabled auto-merge (squash) March 17, 2022 15:51
@stephiescastle stephiescastle merged commit 5a91456 into main Mar 17, 2022
@stephiescastle stephiescastle deleted the feature/58-BlockLinkCard-BlockLinkTile-improvements branch March 17, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature minor Contains new features or enhancements storybook This issue relates to Storybook.js
Projects
None yet
2 participants