-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove top margin from headings that are the first child of `.BlockText #648
Comments
I think I added that top margin intentionally? I thought it was good back when we first added the ability to use headings in rich text, so I went back to look at my PRs. Take a look at #327. Did some new margin get added elsewhere, perhaps? |
Yeah, it makes sense to add margins to headings within BlockText, but the issue is the margin on headings when they're the first child. You can see it happening here: https://www.jpl.nasa.gov/preview?content_type=information_pages.contentpage&token=id=131060:1swQ5C:19cXLl06EIeg3G75OaPz8vVFULWyQMDhECerNi-G5yw&path=/blended-worlds |
Yeah, I just want to believe I would have thought to account for that before 😆 But very possible I did not. |
Maybe the use-case at the time was predominantly wanting to add headings without stopping the flow of BlockText, and BlockHeading was always added first, separately? |
In code review #649 |
Now that headings can be added in rich text, we're getting a double margin when they are the first element within
.BlockText
.We need to remove the top margin of all headings that fit this use-case.
The text was updated successfully, but these errors were encountered: