Skip to content

Add concurrency to docs workflow - #63

Merged
mtmk merged 1 commit into
mainfrom
docs-concurrency
Apr 22, 2026
Merged

Add concurrency to docs workflow#63
mtmk merged 1 commit into
mainfrom
docs-concurrency

Conversation

@mtmk

@mtmk mtmk commented Apr 22, 2026

Copy link
Copy Markdown
Member

Adds a pages concurrency group to .github/workflows/docs.yml so two overlapping pushes to main can't race on the same Pages deployment. Matches GitHub's starter Pages workflow.

@synadia-claude-reviewer

synadia-claude-reviewer Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Claude finished @mtmk's task in 33s —— View job


PR Review

  • Gather context: read PR diff and workflow file
  • Review changes for correctness and security
  • Post review

The change is correct and minimal. Adding a workflow-level concurrency block prevents two overlapping pushes to main from racing on the same Pages deployment — exactly the problem described.

A few observations:

  • cancel-in-progress: false is the right choice here. It queues a second run rather than cancelling it, so every push to main eventually gets deployed and docs are never left in a stale state from a cancelled run.
  • Static group name pages is appropriate. Since the workflow only triggers on main, there's no need for a dynamic group like ${{ github.ref }}; the static name matches GitHub's own starter Pages workflow.
  • Placement at the workflow level (not inside a job) is correct — it gates the entire workflow run, preventing the deploy step from even starting if another run is already in progress.

No correctness, security, or performance issues. This is a safe, well-scoped change.

@codecov

codecov Bot commented Apr 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.44%. Comparing base (a17b4b2) to head (86290f9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   85.44%   85.44%           
=======================================
  Files          51       51           
  Lines         756      756           
  Branches       97       97           
=======================================
  Hits          646      646           
  Misses         81       81           
  Partials       29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scottf scottf left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk
mtmk merged commit 8e908b2 into main Apr 22, 2026
20 checks passed
@mtmk
mtmk deleted the docs-concurrency branch April 22, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants