Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New" page doesn't show the "not logged in" error when saving to Google #1413

Open
calculuschild opened this issue Jun 27, 2021 · 3 comments
Labels
bug We say this works but it doesn't

Comments

@calculuschild
Copy link
Member

This is one of the more common issues on the Subreddit. If you are signed in with Google, the Homebrewery will by default try to save the new brew to your Google Drive. However, if your credentials are expired, the save button will just get stuck with no warning to the user (and the user can't create any new brews). See for example: https://www.reddit.com/r/homebrewery/comments/o24njc/issue_anything_generated_from_new_wont_save/

Signing in and out via google fixes the issue, but we need to communicate this to the user. The Edit page already has an error bubble that pops up telling the user to sign in to Google, but this isn't present on the New page. Should be relatively simple to copy that behavior over.

@calculuschild calculuschild added the bug We say this works but it doesn't label Aug 9, 2021
@calculuschild
Copy link
Member Author

Would be fixed by #1423

@dbolack-ab
Copy link
Collaborator

Is this now fixed by #1801 ?

@calculuschild
Copy link
Member Author

Is this now fixed by #1801 ?

#1801 was never completed and so was not merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug We say this works but it doesn't
Projects
None yet
Development

No branches or pull requests

2 participants