-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI Feature] Add diagnostic information to account menu #2043
Comments
Labeling it a "diagnostics" page is something I haven't really seen before and might be confusing to users. If we need a place to solve user issues, I think those diagnostics should instead be included in the error message somehow. Average users aren't going to think to check some "diagnostics" button when something goes wrong. However, I see this turning into a simple Also, we have technically been using "sign in with google" as the solution to a lot more than just "credentials expired". There are multiple different error codes that we get; at first we only showed the "sign in again" message for a 403 I think, but there are others, and eventually we just showed that message for all google-related issues because we kept getting complaints on the github. I'm pretty sure we've seen some cases where a user just barely signed in and was having some issue, and it turns out the Google Drive was full, or they were trying to access it from a different google account, etc. With that in mind, I agree with most of the bullet points except:
Also, for the future, such an account page might be a good place to put a password-change interface? (separate PR) |
Check if we can read the Homebrewery directory on the user's linked Google Drive account.
This was more for the users reporting problems but not actually sharing a brew link that demonstrates the issue (as in #1238). If this was a "My Account Information" page instead of a pop up/over message window, it would never be relevant. The simplest solution would be to generate the text as a Brew, then push it through the SharePage for display (effectively using SharePage as a BasePage). It may be beneficial - mostly for DRY purposes - to first separate SharePage to a BasePage, say "ViewPage.jsx" that takes NavBarElements as a prop, rather than the current solution where SharePage alters it's behaviour based on the existence of |
Examples of errors that we typically send users to "refresh Google Credentials" but that is not necessarily the solution: 503A 503 means our server was contacted but was (busy?) and couldn't process the request. Usually solved by just saving again after a couple seconds. 500500 Means our server is broken. Usually we get this if the server crashes. 404https://www.reddit.com/r/homebrewery/comments/t8me6a/issue_describe_your_issue_here/
403The real "credentials expired" or "not logged in with Google" error. Refreshing credentials is required. |
Should we actually just fix our error messaging to handle each of these errors differently? Also, I'm going to copy/paste your 'definitions' from that comment and put it in the github Wiki just so I can reference it later. |
Ideally, yes. Right now, the only popup that actually says "refresh your credentials" is if the error comes from Google. That handles the 404 and 403 issues above.
Everything else we just say "oops! Looks like there was a problem saving. Report your issue here: link to Github". So we could potentially be more clear on those other ones. We still want them to report the issue on a 500 or 503 because that means something may be broken on our end, but we could be more clear: 503 "Looks like our servers are a more busy than usual! Wait a couple of seconds and then try saving again. If this keeps happening, report the issue here:" 500 "Aah! Our servers are having trouble saving your document. Make a backup of your brew, and report your issue here to let us know:" |
Fixed by #2161 |
Commonly reported issues in the subreddit and here on GitHub revolve around users being unaware whether their account is connected to Google, or that their Google refresh token is expired.
I propose that we add an additional item to the new Account dropdown menu (added in PR #2015) to allow the user to display some of the information, decoded from the JWT cookie, in order to assist with diagnostics, self or otherwise.
Specifically, I suggest we show the following information:
This could currently be achieved through a simple
alert()
box, although we may also wish to create an information window that is more in line with the Homebrewery UI. It may be worth considering shifting the REPORT ISSUE button to the new Diagnostics window, and including the diagnostic information in the automatically generated Issue Report template.I believe that such a feature would help reduce some of the current issue reports, and hopefully aid in the swift resolution of future issues.
The text was updated successfully, but these errors were encountered: