Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brewTitle in top navbar should not have a "click-me" cursor #2689

Open
ericscheid opened this issue Feb 23, 2023 · 3 comments
Open

brewTitle in top navbar should not have a "click-me" cursor #2689

ericscheid opened this issue Feb 23, 2023 · 3 comments
Assignees
Labels
P3 - low priority Obscure tweak or fix for a single user solution found A solution exists; just needs to be applied tweak Small, non-breaking change UI/UX User Interface, user experience

Comments

@ericscheid
Copy link
Collaborator

Renderer

v3

Browser

Chrome

Operating System

Windows

What happened?

On all pages that have a main navbar which has a title (i.e. pretty much all pages except the literal home page) .. the page/brew title has cursor: pointer as a css rule. Clicking the title does nothing.

image

There is also a CSS rule for .brewTitle.navItem
image
so we can simply add cursor: unset; to that.

Solution

Add cursor: unset to the CSS rule for .brewItem.navItem.

Code

No response

@ericscheid ericscheid added solution found A solution exists; just needs to be applied tweak Small, non-breaking change UI/UX User Interface, user experience P3 - low priority Obscure tweak or fix for a single user labels Feb 23, 2023
@Gazook89
Copy link
Collaborator

This is because it used to be possible to change the title by clicking into that navbar item. It’s a long defunct function (there is a remnant of it somewhere).

For awhile I thought it would be cool to bring that back, but I also think there is some merit in displaying meta info onClick, or similar.

I will take a crack at this since when I work on that other navbar issue.

@Gazook89 Gazook89 self-assigned this Mar 13, 2023
@ericscheid
Copy link
Collaborator Author

Alternatively, clicking the title in the nav-bar on the /edit page could open the Properties panel in the editor.

See also #1679 for the /share page.

@5e-Cleric
Copy link
Member

Update in October, now this cursor:pointer is required for accessibility purposes in the share page, but unwanted in edit pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 - low priority Obscure tweak or fix for a single user solution found A solution exists; just needs to be applied tweak Small, non-breaking change UI/UX User Interface, user experience
Projects
None yet
Development

No branches or pull requests

3 participants