Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHB footers should default to all caps? #3103

Open
calculuschild opened this issue Oct 16, 2023 · 5 comments
Open

PHB footers should default to all caps? #3103

calculuschild opened this issue Oct 16, 2023 · 5 comments
Labels
tweak Small, non-breaking change

Comments

@calculuschild
Copy link
Member

calculuschild commented Oct 16, 2023

Copied from #2289:

@5e-Cleric :
This footer should transform text to CAPS automatically, in the PHB theme, reopening the issue to track that change.
If a javascript change is not optimal, this CSS will do it:

.footnote {
  text-transform:uppercase;
}
@5e-Cleric 5e-Cleric added the tweak Small, non-breaking change label Oct 18, 2023
@G-Ambatte
Copy link
Collaborator

This is an interesting question - SHOULD the text transform to caps? This behavior isn't clearly indicated by the footnote tag, so might be surprising/confusing to users.

I would suggest an alternative styling of .footnote.caps { text-transform: uppercase; } and then adjust the snippet to apply {{footnote,caps [...]}} instead.

@5e-Cleric
Copy link
Member

I disagree on that, a footnote has a series of properties, and most off the time, all caps is one of them, i thought it did until i sent that message.

But i don't really care, it won't make my brews any longer, both options are okay.

This is a perfect issue for new users to contribute.

@Gazook89
Copy link
Collaborator

It’s a stylistic change, to match PHB— I don’t think it is onerous/unexpected that the footnote would be all caps. Same deal as the small caps on the first line after h1 headers.

THAT SAID, we could have a no-caps class that removes the uppercase property (rather than a class that adds it). This could also be applied to a paragraph that has the first line capitalized by using injection curlies, rather than/in addition to the method offered in the Style Editor snippets.

@G-Ambatte
Copy link
Collaborator

I think that the only thing that we can rely on is that users expect that the current behaviour of the footnote will continue in the future, so the styling of .footnote should ideally remain unchanged, thus preventing any unexpected changes to existing documents - even if that change is only "this tiny piece of text is all caps now".
It does seem like this would be perfect for the Theme Versioning change that I mentioned in a comment on that issue earlier today (here) to allow users to stay on their current version if they so desired. But that's a pretty enormous change, and ideally Themes will be live and available to users for some time before we even consider beginning work on that feature.

With that said, I'm not strongly for or against either position, and the actual change itself is only a handful of lines of styling; I'm certain that we can quickly knock out a PR to apply the desired change, whatever it might be.

I also really enjoy the discussion; it's great that we have enough people active enough to discuss the issue.

@5e-Cleric
Copy link
Member

It is nice the possibility of having a discussion, but we better use our time in interesting features, rather than missing nuances.

I say, add a CAPS class, and let there be riot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tweak Small, non-breaking change
Projects
None yet
Development

No branches or pull requests

4 participants