Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDITOR] Unsaved Changes on Exit #3238

Open
G-Ambatte opened this issue Jan 11, 2024 · 0 comments
Open

[EDITOR] Unsaved Changes on Exit #3238

G-Ambatte opened this issue Jan 11, 2024 · 0 comments
Labels
Approved Has been discussed and an approach is agreed upon bug We say this works but it doesn't

Comments

@G-Ambatte
Copy link
Collaborator

Your idea:

Reproduction Steps:

  1. Open any document.
  2. Make a change. Note that the "AUTOSAVE" icon changes to "SAVE NOW"
  3. Revert that change. Note that the "SAVE NOW" reverts to "AUTOSAVE"
  4. Attempt to close the tab.

Despite the fact that there are no changes to be saved, the "Your changes may be lost" warning appears.

image

Solution: update the function called at editor close to use the same logic as the SAVE button.

@calculuschild calculuschild added the Approved Has been discussed and an approach is agreed upon label Jan 11, 2024
@5e-Cleric 5e-Cleric added the bug We say this works but it doesn't label Feb 13, 2024
@dbolack-ab dbolack-ab self-assigned this Dec 12, 2024
@dbolack-ab dbolack-ab removed their assignment Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Has been discussed and an approach is agreed upon bug We say this works but it doesn't
Projects
None yet
Development

No branches or pull requests

4 participants