Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking to ID's works only some of the times. #3272

Open
pjeurien opened this issue Jan 27, 2024 · 2 comments
Open

Linking to ID's works only some of the times. #3272

pjeurien opened this issue Jan 27, 2024 · 2 comments

Comments

@pjeurien
Copy link

Renderer

v3

Browser

Chrome

Operating System

Windows

What happened?

I am creating a list of links in a markdown table and it does not work for all off the links.

None of the links with an & works, they get stripped out in the id.
Eg: meats & more becomes meats--more.

For others it's a mixed bag. Sometimes they work, sometimes they don't. The id's are not duplicated in the brew.

Code

|Type|Shop|District|
|:----|:----|:----|
|Antiquities|[Relic’s & Rarities](#relics--rarities)|Veiled Corner|
|Bakery|[Oliver’s Bakery](#olivers-bakery)|Park Way|
|Blacksmith|[Sutah’s Flame](#sutahs-flame)|The Commons|
|Bookstore|[Badai’s Books and Bindings](#badais-books-and-bindings)|Elder’s Seat|
|Butcher|[Meats & More](#meats--more)|The Commons|
|Conservatorium|[Baroc’s Conservatorium](#barocs-conservatorium)|Artist’s Quarter|
|Flowershop|[The Pettle Trail](#the-pettle-trail)|Park Way|
|General Store|[Roman’s General Store](#romans-general-store)|The Commons|
|Inn|[The Little Lantern Lounge](#the-little-lantarn-lounge)|-|
|Inn|The Old Haunt|Park Way|
|Stable|[Pets & Paws](#pets--paws)|Park Way|
|Tabacco|Tabar’s Tabacco|The Commons|
|Tailor|[Adeline’s Wardrobe](#adelines-wardrobe)|Artist’s Quarter|
|Temple|Church of the Fey|Mourner’s Row|
@5e-Cleric
Copy link
Member

Here's the thing, for now, if a brew is longer than 50 pages, Partial Page Rendering is activated, which only renders a few pages to improve performance.

When that happens, a link will only work between rendered pages, as reported in #1923, recently fixed.
But that will only fix page links, which we use in the ToC, for the rest of links we are working on a fix, #3262, which should keep a record of all headings so you can link to them even if they are not rendered.

TLDR: we're already on it.

@dbolack-ab
Copy link
Collaborator

Regarding the Ampersands, the Heading code uses the GHM slugging rules to generate the id which undoubtedly removes characters that have meanings in URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants