Remove author from brew / promote author to owner

[ericscheid]

Your idea:

Issue #1987 limits /edit/:id access to a list of authors, and facilitates adding authors to that list (via an invitedAuthors intermediary step). The resulting PR #2561 does most of what was requested, but deferred on "removal of authors" (implementing edit authorisation was urgent).

This issue repeats the need for a method for two things:

• removing a co-author from a brew — limited to only authors[0] being permitted to do so
• promoting a co-author to authors[0] — to hand over control

[ericscheid]

• We'd need to do a code-review to ensure we don't inadvertently shuffle authors[ ] anywhere else.

[dbolack-ab]

The only place I have found authors being updated is this section of the updateBrew API call.

		if(req.account) {
			brew.authors = _.uniq(_.concat(brew.authors, req.account.username));
			brew.invitedAuthors = _.uniq(_.filter(brew.invitedAuthors, (a)=>req.account.username !== a));
		}

This looks to be handling when a user comes in on an in invite and saves the first time. This also suggests to me that you only transition from an invitee to an author by saving.

This was by no means, a thorough review.

[5e-Cleric]

I like this approach, because if done right, its backwards compatible with any of the 700k brews with author