Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CodeMirror to 6 #3511

Open
5e-Cleric opened this issue Jun 3, 2024 · 4 comments
Open

Bump CodeMirror to 6 #3511

5e-Cleric opened this issue Jun 3, 2024 · 4 comments
Labels
Approved Has been discussed and an approach is agreed upon dependencies Pull requests that update a dependency file ❌ Missing from V3 Was planned for V3 but still missing P2 - minor feature or not urgent Minor bugs or less-popular features

Comments

@5e-Cleric
Copy link
Member

5e-Cleric commented Jun 3, 2024 •
edited
Loading

This issue tracks our progress in bumping CodeMirror 5.65 to 6

Right now my first problem trying to, is the folder structure:

Show changes
5.65.1 6.0.1
image image

The first problem are themes, will have to check how are themes handled now.

Issues updating codemirror would be required to fix:

#715
#3645
#611
#2793
#1589
@5e-Cleric 5e-Cleric added dependencies Pull requests that update a dependency file ❌ Missing from V3 Was planned for V3 but still missing P2 - minor feature or not urgent Minor bugs or less-popular features Approved Has been discussed and an approach is agreed upon labels Jun 3, 2024
@5e-Cleric 5e-Cleric self-assigned this Jun 3, 2024
@5e-Cleric
Copy link
Member Author

this is a very big task, too much for me, needs a full rebuild of our code handling codemirror. Next dev who tries, be aware of this.

@5e-Cleric 5e-Cleric removed their assignment Aug 13, 2024
@5e-Cleric
Copy link
Member Author

There is a bug with css folding and nesting, probably solved in CM 6:

image
image

@5e-Cleric 5e-Cleric mentioned this issue Sep 10, 2024
Open
@5e-Cleric 5e-Cleric mentioned this issue Oct 4, 2024
Closed
@5e-Cleric
Copy link
Member Author

5e-Cleric commented Oct 26, 2024 •
edited
Loading

Adding here the bunch of features blocked by this update:

@Gazook89
Copy link
Collaborator

Better mobile support

@5e-Cleric 5e-Cleric mentioned this issue Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Approved Has been discussed and an approach is agreed upon dependencies Pull requests that update a dependency file ❌ Missing from V3 Was planned for V3 but still missing P2 - minor feature or not urgent Minor bugs or less-popular features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gazook89 @5e-Cleric