Usernames involving special symbols (email, etc.) can't log in / view userpage

[calculuschild]

Seems to occur occasionally. Creating this issue to centralize the related threads:

#662, #555, #547, #401, #349

[ericscheid]

Closing #764, re-opening this as not resolved(?)

[calculuschild]

Good catch. I probably closed this by accident when I linked it to the other duplicate.

[ericscheid]

Clicking on my name in the top right corner does nothing but bring me to the same welcome example page thing with all the instructions on it.

Currently, I seem to be unable to access my user profile. When I try and access my profile by clicking on my email in the top right corner, I'm sent back to the main page instead of my user page, meaning I can't access any of the brews that I've currently made or any I make in future. I've tried this on chrome and firefox and I've got the same issue on each browser.

---

However this link works, revealing a published brew: https://homebrewery.naturalcrit.com/user/[email protected]

So, maybe usernames as emails work .. but that says nothing about other edge cases so leaving open.

Note however that the username is case-sensitive: https://homebrewery.naturalcrit.com/user/[email protected]

We need more examples of failures.

[calculuschild]

I think the link generated in the profile button is url encoded, turning the @ symbol into %40 or whatever. We just need to make the button not do that. Or unencode the name in the url before searching for the user profile.

[ericscheid]

https://github.com/naturalcrit/homebrewery/blob/master/client/homebrew/navbar/account.navitem.jsx#L23-L25

return <Nav.item href={`/user/${global.account.username}`} color='yellow' icon='fa-user'>
	{global.account.username}
</Nav.item>;

[5e-Cleric]

naturalcrit/naturalcrit#63 is also interesting to solve this and prevent similar issues.