Implement ordering of PeerEndpoints in Peering (temporary version) #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmatthews
approved these changes
Feb 21, 2024
Contributor
glennmatthews
left a comment
glennmatthews
left a comment
There was a problem hiding this comment.
LGTM, do we need this in develop as well?
|
I think it does need to be in develop as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is lightweight solution and replaces #168 - peering endpoints inside a peering class should be ordered by PK which should help with AWS db environments.
This is intended only to serve as a temporary fix until we finalise and implement #149 . Because of that, we do not implement ordering directly on the
PeerEndpoint, but rather just on two affected queries.