Skip to content

Conversation

@flexable777
Copy link
Contributor

No description provided.

@flexable777 flexable777 requested a review from Copilot October 23, 2025 14:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Kaka version 3 by introducing dynamic version determination based on dates. The main changes include creating a KakaVersionUtil component to centralize version logic, refactoring treatment types to use a new BehandlingWithKvalitetsvurdering interface, and updating configuration files with the version 3 rollout dates.

  • Centralizes Kaka version logic in a new utility component
  • Introduces interface-based type checking for treatments requiring quality assessments
  • Updates configuration with version 3 dates (2025-11-07 for dev, 2026-01-01 for prod)

Reviewed Changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/main/resources/application-prod-gcp.yml Adds KAKA_VERSION_3_DATE configuration for production
src/main/resources/application-dev-gcp.yml Adds KAKA_VERSION_3_DATE configuration for development
src/main/kotlin/no/nav/klage/oppgave/util/KakaVersionUtil.kt New utility component for determining current Kaka version
src/main/kotlin/no/nav/klage/oppgave/service/KlagebehandlingService.kt Refactors to use KakaVersionUtil instead of local version logic
src/main/kotlin/no/nav/klage/oppgave/service/AnkebehandlingService.kt Uses KakaVersionUtil for version determination
src/main/kotlin/no/nav/klage/oppgave/service/OmgjoeringskravbehandlingService.kt Uses KakaVersionUtil for version determination
src/main/kotlin/no/nav/klage/oppgave/service/GjenopptaksbehandlingService.kt Uses KakaVersionUtil for version determination
src/main/kotlin/no/nav/klage/oppgave/service/BehandlingEtterTrygderettenOpphevetService.kt Uses KakaVersionUtil for version determination
src/main/kotlin/no/nav/klage/oppgave/service/BehandlingService.kt Simplifies type checking using BehandlingWithKvalitetsvurdering interface
src/main/kotlin/no/nav/klage/oppgave/service/avslutning/KlagebehandlingSchedulerService.kt Refactors to use BehandlingWithKvalitetsvurdering interface
src/main/kotlin/no/nav/klage/oppgave/domain/behandling/*.kt Implements BehandlingWithKvalitetsvurdering interface on relevant treatment classes
src/main/kotlin/no/nav/klage/oppgave/clients/kaka/KakaApiGateway.kt Updates to use BehandlingWithKvalitetsvurdering interface and dynamic versioning
src/main/kotlin/no/nav/klage/oppgave/clients/kaka/KakaApiClient.kt Generalizes delete method to support multiple versions
src/main/kotlin/no/nav/klage/oppgave/eventlisteners/CleanupAfterBehandlingEventListener.kt Simplifies cleanup using BehandlingWithKvalitetsvurdering interface
src/main/kotlin/no/nav/klage/oppgave/api/controller/MockDataController.kt Uses KakaVersionUtil and adds version 3 support
src/main/kotlin/no/nav/klage/oppgave/api/controller/AdminController.kt Removes obsolete endpoint
src/main/kotlin/no/nav/klage/oppgave/service/AdminService.kt Removes obsolete method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@oyvind-wedoe oyvind-wedoe merged commit 65a69a1 into main Nov 12, 2025
1 check passed
@oyvind-wedoe oyvind-wedoe deleted the kaka-v3 branch November 12, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants