Trigger cache delete requests when thread and conversation notes are updated

Author: frodehoen

src/integration/henvendelse-cache/classes/handlers/ConvNoteCacheHandler.cls

@@ -1,17 +1,25 @@
 global class ConvNoteCacheHandler extends MyTriggers {
     global override void onAfterInsert() {
-        createHenvendelseCacheQueueable((List<Conversation_Note__c>) records);
+        createHenvendelseCacheQueueable(
+            (List<Conversation_Note__c>) records,
+            false
+        );
     }
     global override void onAfterUpdate(Map<Id, SObject> triggerOldMap) {
         //TODO: Sjekk kun for felter som er relevante for cachingen
-        createHenvendelseCacheQueueable((List<Conversation_Note__c>) records);
+        createHenvendelseCacheQueueable(
+            (List<Conversation_Note__c>) records,
+            true
+        );
     }
 
     private void createHenvendelseCacheQueueable(
-        List<Conversation_Note__c> convNoteList
+        List<Conversation_Note__c> convNoteList,
+        Boolean isUpdate
     ) {
         Set<Id> recordIds = ConvNoteCacheFilterHelper.getRecordIdsRequiringCacheClear(
-            convNoteList
+            convNoteList,
+            isUpdate
         );
         if (recordIds.isEmpty()) {
             return;

src/integration/henvendelse-cache/classes/helpers/ConvNoteCacheFilterHelper.cls

@@ -1,12 +1,16 @@
 public with sharing class ConvNoteCacheFilterHelper {
     public static Set<Id> getRecordIdsRequiringCacheClear(
-        List<Conversation_Note__c> convNoteList
+        List<Conversation_Note__c> convNoteList,
+        Boolean isUpdate
     ) {
         ModiaIntegrationUser modiaIntegrationUser = new ModiaIntegrationUser();
         Set<Id> recordIds = new Set<Id>();
         for (Conversation_Note__c convNote : convNoteList) {
-            //Only cache records modified in Salesforce
-            if (convNote.LastModifiedById != modiaIntegrationUser.UserId) {
+            //Only cache records created in Salesforce
+            if (
+                convNote.LastModifiedById != modiaIntegrationUser.UserId ||
+                isUpdate
+            ) {
                 recordIds.add(convNote.Id);
             }
         }

src/integration/henvendelse-cache/classes/helpers/ThreadCacheFilterHelper.cls

@@ -6,12 +6,8 @@ public without sharing class ThreadCacheFilterHelper {
         Set<Id> threadIds = new Set<Id>();
 
         for (Thread__c thread : threadList) {
-            //Only cache records created by Salesforce internal users
-            if (thread.LastModifiedById != modiaIntegrationUser.UserId) {
-                threadIds.add(thread.Id);
-            }
+            threadIds.add(thread.Id);
         }
-
         return threadIds;
     }
 

src/integration/henvendelse-cache/classes/helpers/tests/ConvNoteCacheFilterHelperTest.cls

@@ -21,7 +21,8 @@ public class ConvNoteCacheFilterHelperTest {
 
         Test.startTest();
         Set<Id> result = ConvNoteCacheFilterHelper.getRecordIdsRequiringCacheClear(
-            convNotes
+            convNotes,
+            false //record is created
         );
         Test.stopTest();
 
@@ -68,13 +69,60 @@ public class ConvNoteCacheFilterHelperTest {
 
         Test.startTest();
         Set<Id> result = ConvNoteCacheFilterHelper.getRecordIdsRequiringCacheClear(
-            convNotes
+            convNotes,
+            false //record is created
         );
         Test.stopTest();
 
         Assert.areEqual(0, result.size());
     }
 
+    @IsTest
+    static void shouldReturnOneRecordIdForConvNoteUpdatedByModiaIntegrationUser() {
+        myTriggers.disable(ConvNoteCacheHandler.class);
+
+        Id profileId = [
+            SELECT Id
+            FROM Profile
+            WHERE Name = 'System Administrator'
+            LIMIT 1
+        ]
+        .Id;
+        User modiaIntegrationUser = (User) SharedTestDataFactory.createRecord(
+            new User(
+                username = '[email protected]',
+                ProfileId = profileId
+            )
+        );
+
+        Account personAccount = SharedTestDataFactory.createPersonAccount();
+
+        System.runAs(modiaIntegrationUser) {
+            SharedTestDataFactory.createRecord(
+                new Conversation_Note__c(
+                    CRM_Account__c = personAccount.Id,
+                    CRM_Conversation_Note__c = 'DUMMY TEXT',
+                    CRM_Henvendelse_BehandlingskjedeId__c = '789'
+                )
+            );
+        }
+
+        List<Conversation_Note__c> convNotes = [
+            SELECT Id, LastModifiedById
+            FROM Conversation_Note__c
+            WHERE CRM_Henvendelse_BehandlingskjedeId__c = '789'
+        ];
+
+        Test.startTest();
+        Set<Id> result = ConvNoteCacheFilterHelper.getRecordIdsRequiringCacheClear(
+            convNotes,
+            true //record is updated
+        );
+        Test.stopTest();
+
+        Assert.areEqual(1, result.size());
+    }
+
     @IsTest
     static void shouldReturnOneActorIdWhenOneConversationNoteId() {
         myTriggers.disable(ConvNoteCacheHandler.class);

src/integration/henvendelse-cache/classes/helpers/tests/ThreadCacheFilterHelperTest.cls

@@ -37,7 +37,7 @@ public class ThreadCacheFilterHelperTest {
     }
 
     @IsTest
-    static void shouldNotReturnThreadIdForThreadCreatedByModiaIntegrationUser() {
+    static void shouldReturnOndThreadIdForThreadUpdatedByModiaIntegrationUser() {
         myTriggers.disable(MessageCacheHandler.class);
         myTriggers.disable(ThreadCacheHandler.class);
 
@@ -81,7 +81,7 @@ public class ThreadCacheFilterHelperTest {
         );
         Test.stopTest();
 
-        Assert.areEqual(0, result.size());
+        Assert.areEqual(1, result.size());
     }
 
     @IsTest