[spellcheck] Part 3: Spell check directories debug_scripts and docs #12787
+459
−414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12787 +/- ##
==========================================
- Coverage 70.53% 70.52% -0.01%
==========================================
Files 846 846
Lines 174904 174904
Branches 174904 174904
==========================================
- Hits 123372 123355 -17
- Misses 46282 46296 +14
- Partials 5250 5253 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
miloserdow
approved these changes
Jan 24, 2025
Longarithm
requested changes
Jan 24, 2025
| @@ -107,7 +107,7 @@ collection of old block data which is no longer needed. | |||
| ### TrieRefcountChange | |||
|
|
|||
| Because we remove unused nodes during garbage collection, we need to track | |||
| the reference count (`rc`) for each node. Another reason is that we can dedup | |||
| the reference count (`rc`) for each node. Another reason is that we can de-dup | |||
There was a problem hiding this comment.
didn't find "de-dup" in google, only dedup
docs/practices/workflows/io_trace.md
Outdated
| @@ -236,7 +238,7 @@ Afterwards, a value with 16 bytes (a `u128`) is fetched from the trie state. | |||
| To serve this, it required reading 30 trie nodes, 19 of them were cached in the | |||
| accounting cache and were not charged the full gas cost. And the remaining 11 | |||
| missed the accounting cache but they hit the shard cache. Nothing needed to be | |||
| fetched from DB because the Sweatcoin specific prefetcher has already loaded | |||
| fetched from DB because the SweatCoin specific prefetcher has already loaded | |||
Longarithm
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.