Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClojureScript compat - pt. 2 (minor) #57

Open
3 of 8 tasks
vemv opened this issue May 27, 2019 · 1 comment
Open
3 of 8 tasks

ClojureScript compat - pt. 2 (minor) #57

vemv opened this issue May 27, 2019 · 1 comment

Comments

@vemv
Copy link
Contributor

vemv commented May 27, 2019

aka the pending items from https://github.com/nedap/utils.spec/pull/54 :

  • cover consistent-tagging? and other similar fns
  • Create a specific test for 37e9456 (instance-spec: also check protocols, for cljs)
  • extract-specs-from-metadata can return :type-annotation js/Number (as opposed to 'number), as reflected in unit.nedap.utils.spec.impl.parsing
  • Ensure unit.nedap.utils.speced.defn.pre-post is in sync
  • Create assert for ;; in CLJS, arglists don't ever get a :tag.
  • Upgrade :pres to use check!
  • Maybe: if there's a primitive hint, turn :pres into :posts
    • Rationale: Note that boolean return values will be turned into Booleans, chars will become Characters, and numeric primitives will become Numbers unless they are immediately consumed by a method taking a primitive. https://clojure.org/reference/java_interop
  • README for cljs:
    • mention possible need for requiring Expound
@vemv
Copy link
Contributor Author

vemv commented Jul 26, 2019

Satisfied the most important points for now.

@vemv vemv mentioned this issue Jul 26, 2019
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant