[tools] Create the eslint-config package (#102)

* Add eslint-config package

* Add eslintignore and config file

* Update dependencies

* Set rimraf and babel to specific versions

* Update babel package to use latest configs

* Fix lint issues

* Remove explicit babel-preset 3.0.0 in package.json

* Update babel dependencies

* Use same version of the babel core module

* Add babel-runtime for jest-plugins issues

* Resolve the react-test-renderer to 16.8.3

Author: negativetwelve

.eslintignore

@@ -0,0 +1,3 @@
+build
+coverage
+node_modules

.eslintrc.js

@@ -0,0 +1,3 @@
+module.exports = {
+  extends: '@react-x',
+};

components/primitives/src/__tests__/Primitives.spec.dom.js

@@ -1,6 +1,6 @@
 // Modules
 import React from 'react';
-import {View, Text, Image, Touchable, StyleSheet, Animated} from '../Primitives';
+import {View, Text, Image, Touchable} from '../Primitives';
 
 /* eslint-disable no-undef */
 describe('Primitives', () => {

components/primitives/src/__tests__/Primitives.spec.native.js

@@ -1,6 +1,6 @@
 // Modules
 import React from 'react';
-import {View, Text, Image, Touchable, StyleSheet, Animated} from '../Primitives';
+import {View, Text, Image, Touchable} from '../Primitives';
 
 /* eslint-disable no-undef */
 describe('Primitives', () => {

components/switch/src/SwitchX.dom.js

@@ -18,16 +18,11 @@ const SwitchX = (props) => (
 SwitchX.propTypes = {
   onTintColor: PropTypes.string.isRequired,
   isOn: PropTypes.bool.isRequired,
-  isDisabled: PropTypes.bool.isRequired,
   onChange: PropTypes.func,
-  tintColor: PropTypes.string,
-  thumbTintColor: PropTypes.string,
 };
 
 SwitchX.defaultProps = {
   onChange: null,
-  tintColor: null,
-  thumbTintColor: null,
 };
 
 

components/text-input/src/TextInput.js

@@ -1,4 +1,4 @@
 // React X
 // NOTE(mark): Until we need custom functionality, we should assume react-native
 // and react-native-web export a consistent TextInput.
-export default from './TextInputX';
+export {default} from './TextInputX';

modules/clipboard/src/Clipboard.js

@@ -1 +1 @@
-export default from './ClipboardX';
+export {default} from './ClipboardX';

modules/keychain/src/Keychain.js

@@ -10,7 +10,6 @@ import KeychainX from './KeychainX';
  * Persistent secure storage for all apps.
  */
 class Keychain {
-
   // --------------------------------------------------
   // Initialize
   // --------------------------------------------------
@@ -48,10 +47,7 @@ class Keychain {
   // Private
   // --------------------------------------------------
   assertInitialized(method) {
-    invariant(
-      this.initialized,
-      `Keychain calling '${method}' before it has been initialized.`,
-    );
+    invariant(this.initialized, 'Keychain calling method before it has been initialized.');
   }
 
   async setEntries(entries = {}) {
@@ -76,7 +72,6 @@ class Keychain {
     this.all = omit(this.all, keys);
     return this.keychain.clearKeys(keys, this.all, this.options);
   }
-
 }
 
 

modules/keychain/src/KeychainX.dom.js

@@ -6,7 +6,6 @@ import Cookies from 'cookies-js';
  * Persistent secure storage for the web. Wrapper around Cookies for the web.
  */
 class KeychainX {
-
   async getEntries(keys = []) {
     const accumulate = (all, key) => {
       all[key] = Cookies.get(key);
@@ -25,7 +24,6 @@ class KeychainX {
   async clearKeys(keys = [], all = {}, options = {}) {
     return keys.map((key) => Cookies.expire(key, options));
   }
-
 }
 
 

modules/keychain/src/KeychainX.native.js

@@ -1,6 +1,5 @@
 // Libraries
 import * as RNKeychain from 'react-native-keychain';
-import omit from 'lodash.omit';
 import pick from 'lodash.pick';
 
 
@@ -9,7 +8,6 @@ import pick from 'lodash.pick';
  * native keychain module on iOS and shared preferences on Android.
  */
 class KeychainX {
-
   constructor({namespace}) {
     this.namespace = namespace;
   }
@@ -18,7 +16,7 @@ class KeychainX {
     try {
       // We store all key/values in the password field.
       const data = await RNKeychain.getGenericPassword(this.namespace);
-      const {username, password} = data;
+      const {password} = data;
       const all = JSON.parse(password);
 
       // Only return the key / values for the keys we specified.
@@ -49,7 +47,6 @@ class KeychainX {
     // Set the remaining values on the keychain again.
     return this.save(all);
   }
-
 }
 
 

modules/keychain/src/__tests__/Keychain.spec.js

@@ -80,7 +80,9 @@ describe('Keychain', () => {
           context('with keys in all', () => {
             set('key', () => 'test');
             set('all', () => ({test: 'value'}));
-            beforeEach(() => keychain.all = all);
+            beforeEach(() => {
+              keychain.all = all;
+            });
 
             it('should return the value', () => {
               expect(get()).toEqual('value');

package.json

@@ -6,31 +6,22 @@
     "yarn": ">=1.0.1"
   },
   "devDependencies": {
-    "@babel/core": "^7.4.4",
-    "@react-x/babel-preset": "3.0.0",
-    "coveralls": "^2.13.1",
-    "eslint": "^4.4.1",
-    "eslint-config-jolt": "^2.6.1",
-    "eslint-plugin-jest": "^21.0.2",
-    "husky": "^0.14.3",
-    "jest": "^24.8.0",
+    "@babel/core": "7.6.2",
+    "coveralls": "3.0.7",
+    "husky": "0.14.3",
+    "jest": "24.8.0",
     "lerna": "3.18.3",
-    "lint-staged": "^4.0.3",
+    "lint-staged": "4.0.3",
     "react": "16.8.3",
     "react-art": "16.8.3",
     "react-dom": "16.8.3",
     "react-native": "0.59.8",
     "react-native-web": "0.11.4",
-    "rimraf": "^2.6.1"
+    "rimraf": "2.6.1"
   },
-  "eslintConfig": {
-    "extends": "jolt"
+  "resolutions": {
+    "react-test-renderer": "16.8.3"
   },
-  "eslintIgnore": [
-    "build",
-    "coverage",
-    "node_modules"
-  ],
   "jest": {
     "projects": [
       "test/jest-config.dom.js",

packages/react-x/src/__tests__/react-x.spec.js

@@ -1,5 +1,4 @@
 // Modules
-import React from 'react';
 import ReactX from '../react-x';
 
 /* eslint-disable no-undef */

tools/babel-preset/index.js

@@ -1,11 +1,11 @@
-module.exports = () => {
+module.exports = (context, options = {}) => {
   return {
     presets: [
       '@babel/preset-env',
       '@babel/preset-react',
     ],
     plugins: [
-      '@babel/plugin-proposal-export-default-from',
+      '@babel/plugin-proposal-class-properties',
       '@babel/plugin-transform-flow-strip-types',
       '@babel/plugin-transform-runtime',
     ],

tools/babel-preset/package.json

@@ -1,16 +1,18 @@
 {
   "name": "@react-x/babel-preset",
   "version": "3.1.0",
+  "dependencies": {
+    "@babel/runtime": "7.5.5"
+  },
   "devDependencies": {
-    "@babel/cli": "^7.4.4",
-    "@babel/core": "^7.4.4",
-    "@babel/plugin-proposal-export-default-from": "^7.2.0",
-    "@babel/plugin-transform-flow-strip-types": "^7.4.4",
-    "@babel/plugin-transform-runtime": "^7.4.4",
-    "@babel/preset-env": "^7.4.4",
-    "@babel/preset-react": "^7.0.0",
-    "@babel/runtime": "^7.4.4",
-    "babel-jest": "^24.8.0"
+    "@babel/cli": "7.6.2",
+    "@babel/core": "7.6.2",
+    "@babel/plugin-proposal-class-properties": "7.5.5",
+    "@babel/plugin-transform-flow-strip-types": "7.6.3",
+    "@babel/plugin-transform-runtime": "7.6.2",
+    "@babel/preset-env": "7.6.2",
+    "@babel/preset-react": "7.0.0",
+    "babel-runtime": "6.26.0"
   },
   "scripts": {}
 }

tools/eslint-config/package.json

@@ -0,0 +1,19 @@
+{
+  "name": "@react-x/eslint-config",
+  "version": "3.1.0",
+  "main": "src/eslintrc.js",
+  "dependencies": {
+    "@typescript-eslint/eslint-plugin": "1.13.0",
+    "@typescript-eslint/parser": "1.13.0",
+    "babel-eslint": "10.0.3",
+    "eslint": "5.16.0",
+    "eslint-config-airbnb": "18.0.1",
+    "eslint-config-react-app": "4.0.1",
+    "eslint-plugin-flowtype": "2.50.3",
+    "eslint-plugin-import": "2.18.2",
+    "eslint-plugin-jsx-a11y": "6.2.3",
+    "eslint-plugin-react": "7.16.0",
+    "eslint-plugin-react-hooks": "1.7.0",
+    "typescript": "3.6.4"
+  }
+}

tools/eslint-config/src/eslintrc.js

@@ -0,0 +1,54 @@
+module.exports = {
+  extends: [
+    'airbnb',
+    'react-app',
+  ],
+  rules: {
+    'indent': [2, 2, {SwitchCase: 1}],
+    'no-unused-vars': 2,
+    'object-curly-newline': [2, {multiline: true, consistent: true}],
+    'object-curly-spacing': [2, 'never'],
+    'operator-linebreak': [2, 'after'],
+    'quote-props': [2, 'consistent-as-needed'],
+    'react/jsx-closing-bracket-location': [2, 'tag-aligned'],
+    'max-len': [2, 100],
+
+    // TODO(mark): These should be turned on but requires a larger change.
+    'arrow-body-style': 0,
+    'arrow-parens': 0,
+    'consistent-return': 0,
+    'global-require': 0,
+    'no-console': 0,
+    'no-confusing-arrow': 0,
+    'no-else-return': 0,
+    'no-nested-ternary': 0,
+    'no-param-reassign': 0,
+    'no-shadow': 0,
+    'no-useless-return': 0,
+    'quotes': 0,
+    'import/no-extraneous-dependencies': 0,
+    'import/no-unresolved': 0,
+    'react/forbid-prop-types': 0,
+    'react/prop-types': 0,
+
+    // TODO(mark): These rules have issues with the shared/<package> packages.
+    'class-methods-use-this': 0,
+    'no-underscore-dangle': 0,
+    'react/destructuring-assignment': 0,
+    'react/no-find-dom-node': 0,
+    'react/no-string-refs': 0,
+    'react/no-unused-state': 0,
+    'react/sort-comp': 0,
+    'react/state-in-constructor': 0,
+
+    // TODO(mark): Need to double check if we want these off or not.
+    'import/prefer-default-export': 0,
+    'react/jsx-curly-brace-presence': 0,
+    'react/jsx-filename-extension': 0,
+    'react/jsx-fragments': 0,
+    'react/jsx-props-no-spreading': 0,
+    'react/no-array-index-key': 0,
+    'react/no-children-prop': 0,
+    'react/no-unescaped-entities': 0,
+  },
+};