Skip to content

Commit 9c8706b

Browse files
committed
Fix images tag issue.
move the image tag out only remove the first : in the keypair.
1 parent 3d943d5 commit 9c8706b

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,9 +284,11 @@ modify_composefile: modify_composefile_notary modify_composefile_clair
284284
@cp $(DOCKERCOMPOSEFILEPATH)/$(DOCKERCOMPOSETPLFILENAME) $(DOCKERCOMPOSEFILEPATH)/$(DOCKERCOMPOSEFILENAME)
285285
@cp $(DOCKERCOMPOSEFILEPATH)/ha/$(DOCKERCOMPOSETPLFILENAME) $(DOCKERCOMPOSEFILEPATH)/ha/$(DOCKERCOMPOSEFILENAME)
286286
@$(SEDCMD) -i 's/__version__/$(VERSIONTAG)/g' $(DOCKERCOMPOSEFILEPATH)/ha/$(DOCKERCOMPOSEFILENAME)
287-
@$(SEDCMD) -i 's/__reg_version__/$(REGISTRYVERSION)-$(VERSIONTAG)/g' $(DOCKERCOMPOSEFILEPATH)/$(DOCKERCOMPOSEFILENAME)
288287
@$(SEDCMD) -i 's/__version__/$(VERSIONTAG)/g' $(DOCKERCOMPOSEFILEPATH)/$(DOCKERCOMPOSEFILENAME)
288+
@$(SEDCMD) -i 's/__reg_version__/$(REGISTRYVERSION)-$(VERSIONTAG)/g' $(DOCKERCOMPOSEFILEPATH)/$(DOCKERCOMPOSEFILENAME)
289+
@$(SEDCMD) -i 's/__reg_version__/$(REGISTRYVERSION)-$(VERSIONTAG)/g' $(DOCKERCOMPOSEFILEPATH)/ha/$(DOCKERCOMPOSEFILENAME)
289290
@$(SEDCMD) -i 's/__nginx_version__/$(NGINXVERSION)/g' $(DOCKERCOMPOSEFILEPATH)/$(DOCKERCOMPOSEFILENAME)
291+
@$(SEDCMD) -i 's/__nginx_version__/$(NGINXVERSION)/g' $(DOCKERCOMPOSEFILEPATH)/ha/$(DOCKERCOMPOSEFILENAME)
290292

291293
modify_composefile_notary:
292294
@echo "preparing docker-compose notary file..."

make/ha/docker-compose.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ services:
1212
networks:
1313
- harbor
1414
registry:
15-
image: vmware/registry:2.6.2-photon
15+
image: vmware/registry-photon:__reg_version__
1616
container_name: registry
1717
restart: always
1818
volumes:
@@ -95,7 +95,7 @@ services:
9595
syslog-address: "tcp://127.0.0.1:1514"
9696
tag: "jobservice"
9797
proxy:
98-
image: vmware/nginx-photon:1.11.13
98+
image: vmware/nginx-photon:__nginx_version__
9999
container_name: nginx
100100
restart: always
101101
volumes:

make/prepare

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ else:
265265
storage_provider_name = rcp.get("configuration", "registry_storage_provider_name").strip()
266266
storage_provider_config = rcp.get("configuration", "registry_storage_provider_config").strip()
267267
# yaml requires 1 or more spaces between the key and value
268-
storage_provider_config = storage_provider_config.replace(":", ": ")
268+
storage_provider_config = storage_provider_config.replace(":", ": ", 1)
269269

270270
ui_secret = ''.join(random.choice(string.ascii_letters+string.digits) for i in range(16))
271271
jobservice_secret = ''.join(random.choice(string.ascii_letters+string.digits) for i in range(16))

0 commit comments

Comments
 (0)