-
Notifications
You must be signed in to change notification settings - Fork 0
Fix line search for grad reconstruction method #13
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or requestnumericsIssue with numerical methodsIssue with numerical methodsreconstructionIssues related to the reconstruction of quantum states from observed frequenciesIssues related to the reconstruction of quantum states from observed frequencies
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or requestnumericsIssue with numerical methodsIssue with numerical methodsreconstructionIssues related to the reconstruction of quantum states from observed frequenciesIssues related to the reconstruction of quantum states from observed frequencies
The
sqt.fit.grad.line_searchfunction does not work properly on some (most? all?) inputs as described in the docstring:Fixing it would:
gradreconstruction method,gradreconstruction method more robust, as a fixed step of1e-5does not provide us any guarantee of convergence.