V3.8.1 to master (#3941)

* [`Optimize`]: show native contract is active or not (#3922)

* optimize: show native contract net active yet

* Update src/Neo.CLI/CLI/MainService.Native.cs

* style: move BigInteger extensions from Utility to BigIntegerExtensions (#3916)

---------

Co-authored-by: Shargon <[email protected]>

* Avoid empty snupkg in release (#3925)

* v3.8.1 (#3930)

* Revert workflow branch

---------

Co-authored-by: Will <[email protected]>
Co-authored-by: Shargon <[email protected]>

Author: 3 people

.github/workflows/nuget.yml

@@ -38,6 +38,7 @@ jobs:
         --output ${{ env.NEO_NUGET_DIR }} \
         --verbosity normal \
         -p:VersionPrefix=${{ env.APP_VERSION }} \
+        -p:IncludeSymbols=false \
         -p:DebugSymbols=false \
         -p:DebugType=none \
         -p:ServerGarbageCollection=true \

src/Directory.Build.props

@@ -23,7 +23,7 @@
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <Company>The Neo Project</Company>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <VersionPrefix>3.8.0</VersionPrefix>
+    <VersionPrefix>3.8.1</VersionPrefix>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <WarningLevel>4</WarningLevel>
     <AnalysisLevel>latest</AnalysisLevel>

src/Neo.CLI/CLI/MainService.Blockchain.cs

@@ -208,20 +208,27 @@ public void OnShowContractCommand(string nameOrHash)
             lock (syncRoot)
             {
                 ContractState? contract = null;
-
-                if (UInt160.TryParse(nameOrHash, out var scriptHash))
+                NativeContract? nativeContract = null;
+                var isHash = UInt160.TryParse(nameOrHash, out var scriptHash);
+                if (isHash)
+                {
                     contract = NativeContract.ContractManagement.GetContract(NeoSystem.StoreView, scriptHash);
+                    if (contract is null)
+                        nativeContract = NativeContract.Contracts.SingleOrDefault(s => s.Hash == scriptHash);
+                }
                 else
                 {
-                    var nativeContract = NativeContract.Contracts.SingleOrDefault(s => s.Name.Equals(nameOrHash, StringComparison.InvariantCultureIgnoreCase));
-
+                    nativeContract = NativeContract.Contracts.SingleOrDefault(s => s.Name.Equals(nameOrHash, StringComparison.InvariantCultureIgnoreCase));
                     if (nativeContract != null)
                         contract = NativeContract.ContractManagement.GetContract(NeoSystem.StoreView, nativeContract.Hash);
                 }
 
                 if (contract is null)
                 {
-                    ConsoleHelper.Error($"Contract {nameOrHash} doesn't exist.");
+                    var state = nativeContract is null
+                        ? "doesn't exist"
+                        : isHash ? $"({nativeContract.Name}) not active yet" : "not active yet";
+                    ConsoleHelper.Error($"Contract {nameOrHash} {state}.");
                     return;
                 }
 

src/Neo.CLI/CLI/MainService.Native.cs

@@ -23,7 +23,12 @@ partial class MainService
         [ConsoleCommand("list nativecontract", Category = "Native Contract")]
         private void OnListNativeContract()
         {
-            NativeContract.Contracts.ToList().ForEach(p => ConsoleHelper.Info($"\t{p.Name,-20}", $"{p.Hash}"));
+            var currentIndex = NativeContract.Ledger.CurrentIndex(NeoSystem.StoreView);
+            NativeContract.Contracts.ToList().ForEach(contract =>
+            {
+                var active = contract.IsActive(NeoSystem.Settings, currentIndex) ? "" : " not active yet";
+                ConsoleHelper.Info($"\t{contract.Name,-20}", $"{contract.Hash}{active}");
+            });
         }
     }
 }

src/Neo/SmartContract/Native/NativeContract.cs

@@ -330,7 +330,7 @@ internal bool IsInitializeBlock(ProtocolSettings settings, uint index, [NotNullW
         /// <param name="settings">The <see cref="ProtocolSettings"/> where the HardForks are configured.</param>
         /// <param name="blockHeight">Block height</param>
         /// <returns>True if the native contract is active</returns>
-        internal bool IsActive(ProtocolSettings settings, uint blockHeight)
+        public bool IsActive(ProtocolSettings settings, uint blockHeight)
         {
             if (ActiveIn is null) return true;