clean

Author: shargon

src/Neo/SmartContract/Manifest/ContractParameterDefinition.cs

@@ -60,8 +60,7 @@ public StackItem ToStackItem(IReferenceCounter referenceCounter)
 
             if (ExtendedType != null)
             {
-                var structExtended = new Struct(referenceCounter);
-                item.Add(ExtendedType.ToStackItem(referenceCounter, structExtended));
+                item.Add(ExtendedType.ToStackItem(referenceCounter));
             }
 
             return item;

src/Neo/SmartContract/Manifest/ExtendedType.cs

@@ -179,9 +179,7 @@ internal StackItem ToStackItem(IReferenceCounter referenceCounter, Struct array)
             if (Value is null) array.Add(StackItem.Null);
             else
             {
-                var arrayValue = new Struct(referenceCounter);
-                Value.ToStackItem(referenceCounter, arrayValue);
-                array.Add(arrayValue);
+                array.Add(Value.ToStackItem(referenceCounter));
             }
             if (Fields is null) array.Add(StackItem.Null);
             else

tests/Neo.UnitTests/SmartContract/Manifest/UT_ExtendedType.cs

@@ -260,11 +260,10 @@ public void ToStackItem_And_FromStackItem_ShouldRoundtrip()
             };
 
             var refCounter = new ReferenceCounter();
-            var structItem = new Struct(refCounter);
-            var stackItem = original.ToStackItem(refCounter, structItem);
+            var structItem = original.ToStackItem(refCounter);
 
             var copy = new ExtendedType();
-            copy.FromStackItem((VM.Types.Array)stackItem);
+            copy.FromStackItem((VM.Types.Array)structItem);
 
             Assert.AreEqual(original.Type, copy.Type);
             Assert.AreEqual(original.NamedType, copy.NamedType);