Plugins Loading issue

[superboyiii]

Describe the bug
I found plugins loading has several issues after current changes on dev.

1. RestServer can't load correctly although Applicationlogs can work well. The error is:

System.NullReferenceException: Object reference not set to an instance of an object.
   at Neo.Plugins.ApplicationLogs.LogReader.OnSystemLoaded(NeoSystem system)
   at Neo.NeoSystem..ctor(ProtocolSettings settings, IStoreProvider storageProvider, String storagePath) in E:\PR-test\neo-PR#4202\neo\src\Neo\NeoSystem.cs:line 154
   at Neo.NeoSystem..ctor(ProtocolSettings settings, String storageProvider, String storagePath) in E:\PR-test\neo-PR#4202\neo\src\Neo\NeoSystem.cs:line 128
   at Neo.CLI.MainService.Start(CommandLineOptions options) in E:\PR-test\neo-PR#4202\neo\src\Neo.CLI\CLI\MainService.cs:line 350
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_1(Object state)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()

Seems RestServer is scanning all AppDomain which makes loading conflicts with ApplicationLogs
Here:

WebHost.CreateDefaultBuilder()
    .ConfigureServices((context, services) =>
    {
        services.AddControllers();
    })

2. Can't load SignClient correctly. Error is:

System.ArgumentException: Can't find the storage provider LevelDBStore (Parameter 'storageProvider')
   at Neo.NeoSystem..ctor(ProtocolSettings settings, String storageProvider, String storagePath) in E:\PR-test\neo-PR#4202\neo\src\Neo\NeoSystem.cs:line 128
   at Neo.CLI.MainService.Start(CommandLineOptions options) in E:\PR-test\neo-PR#4202\neo\src\Neo.CLI\CLI\MainService.cs:line 350
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_1(Object state)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()

3. Can't load SqliteWallet correctly. The same error:

neo> System.ArgumentException: Can't find the storage provider LevelDBStore (Parameter 'storageProvider')
   at Neo.NeoSystem..ctor(ProtocolSettings settings, String storageProvider, String storagePath) in E:\PR-test\neo-PR#4202\neo\src\Neo\NeoSystem.cs:line 128
   at Neo.CLI.MainService.Start(CommandLineOptions options) in E:\PR-test\neo-PR#4202\neo\src\Neo.CLI\CLI\MainService.cs:line 350
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_1(Object state)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()

Expected behavior
They all should be loaded correctly.

@shargon @cschuchardt88 @Wi1l-B0t @vncoelho

[shargon]

Could you try without #4225 ?

[superboyiii]

Could you try without #4225 ?

Yes, the issue is from #4225 , reverted and seems until 455e17a, it's still loading correctly.

[vncoelho]

@superboyiii why it was not found before on your tests?

[Jim8y]

@superboyiii why it was not found before on your tests?

its dev branch, issue may exist. its impossible for superboy to run complete test on every pr.

[shargon]

@superboyiii why it was not found before on your tests?

its dev branch, issue may exist. its impossible for superboy to run complete test on every pr.

But this was tested, we need to test the plugins in CI.

#4225 (comment)

[superboyiii]

@superboyiii why it was not found before on your tests?

I tested these common plugins: LevelDB, DBFT, ApplicationLogs, TokenTracker, StateService, StorageDumpers, RpcServer. Unfortunately, they all work well. I will test all plugins next time to ensure they work.

[vncoelho]

But leveldb did not work here neither

[superboyiii]

But leveldb did not work here neither

It works for sure

[vncoelho]

#4225 (comment)

[superboyiii]

But leveldb did not work here neither

You can try only installing LevelDB, it will work. Only these 3 plugins will not work.

[vncoelho]

But leveldb did not work here neither

You can try only installing LevelDB, it will work. Only these 3 plugins will not work.

Makes sense, I will try here.

[superboyiii]

#4225 (comment)

These errors are not from LevelDB plugin. See my test result above. SqliteWallet plugin can cause this. Or we say it's loading conflict, leveldb may be loaded slower than SqliteWallet. That's why multi plugins can't be loaded correctly.

[vncoelho]

Correctly, @superboyiii
I tested here and proceed.

This also gave me a good idea for testing, which is to isolate the tests for each Plugin running on clients.
I will create a script that load each of them, all combinations are many and maybe costly....
but running of each them isolated is good for now, later I can combine.

[Wi1l-B0t]

LevelDB and RocksDB should be loaded before the others.