-
Notifications
You must be signed in to change notification settings - Fork 37
Update notifications around Importing WITH and variable scope clauses #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
renetapopova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments, but my main concern is that we are changing the message of the neo4j codes, which is a breaking change, or I missed something.
renetapopova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks, @Lojjs
70365a8 to
274abe9
Compare
Looks like this was overlooked before.
…recated solution.
274abe9 to
47c1c8b
Compare
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
Update 03N60 to suggest variable scope clause instead of Importing WITH for shadowing as the latter is deprecated.
Update both 03N60 and importing WITH deprecation to include the correct command: CALL or OPTIONAL CALL.
Companion Neo4j PR: https://github.com/neo-technology/neo4j/pull/34657