Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some resource packs can break particle culling #1722

Open
Lolothepro opened this issue Dec 1, 2024 · 2 comments
Open

Some resource packs can break particle culling #1722

Lolothepro opened this issue Dec 1, 2024 · 2 comments
Labels
1.21.1 Targeted at Minecraft 1.21.1 1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error rendering Related to rendering

Comments

@Lolothepro
Copy link
Contributor

Minecraft Version: 1.21.1

NeoForge Version: 21.1.83

Steps to Reproduce:

  1. Apply this resource pack: https://modrinth.com/resourcepack/3d-particles
  2. Enable particle debugging and break a block, or wait for a slime to jump
  3. The particles will have an offset

Description of issue:

2024-12-01_15-50-15_compressed.mp4

The particles are not aligned with the culling hitbox

@Lolothepro Lolothepro added the triage Needs triaging and confirmation label Dec 1, 2024
@XFactHD
Copy link
Member

XFactHD commented Dec 20, 2024

The linked resource pack uses a core shader to generate the 3D geometry, ignoring particle scaling and, crucially, generates them at the wrong height (vanilla block break particles are perfectly centered in the hitbox, the 3D particles are centered at the top edge of the bounding box). The bounding box used for culling is already expanded a bit beyond the particle's collision bounding box, so I don't think there is anything we can realistically do about this.

@sciwhiz12 sciwhiz12 added bug A bug or error rendering Related to rendering 1.21.1 Targeted at Minecraft 1.21.1 1.21.4 Targeted at Minecraft 1.21.4 and removed triage Needs triaging and confirmation labels Dec 23, 2024
@sciwhiz12
Copy link
Member

Given that the resource pack implements its behavior by modifying the core shaders, which is explicitly unsupported by Mojang at the moment, we can't and won't do a lot about this issue.

At most, we could implement a config option to disable particle culling, so users of certain resource packs can disable it as necessary. Outside of that, I don't think we can do much to fix this outside of outright disabling particle culling permanently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1 1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error rendering Related to rendering
Projects
None yet
Development

No branches or pull requests

3 participants