Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.4] Regression in the effects of modded fluids on entity movement. #1832

Open
bconlon1 opened this issue Jan 9, 2025 · 0 comments
Open
Labels
triage Needs triaging and confirmation

Comments

@bconlon1
Copy link
Contributor

bconlon1 commented Jan 9, 2025

Minecraft Version: 1.21.4

NeoForge Version: 21.4.50-beta

Logs: N/A; Code:

Steps to Reproduce:

  1. Create and register a custom fluid that does not incorporate any custom movement effects.
  2. Jump into the fluid.
  3. Notice the player will sink to the bottom immediately and their movement will behave as if they aren't in any fluid; except they are prevented from jumping notably.
java_K9RkEHHrMs.mp4

Description of issue:
It seems like there's been a regression in custom fluid behavior between 1.21.1 and 1.21.4. I believe the difference is in that this patch code from 1.21.1 moved to the LivingEntity#travelInFluid method in 1.21.4, but a patch has not been added here to LivingEntity#travel before the new travelInFluid method is called:
Image

@bconlon1 bconlon1 added the triage Needs triaging and confirmation label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triaging and confirmation
Projects
None yet
Development

No branches or pull requests

1 participant