BUGFIX: Render nested attributes and handle Enum and Object arguments

The code generated by var_export for objects (and enums) is not valid to be used in attributes as those require a constant expression.

This change addresses that by:

- rendering Enums correctly
- rendering other objects by filling constructor arguments with public property or getter values
- handling array arguments by calling the above recursively

Author: mficzel

Neos.Flow/Classes/ObjectManagement/Proxy/Compiler.php

@@ -291,18 +291,95 @@ public static function renderAttribute(ReflectionAttribute $attribute): string
         if (count($attribute->getArguments()) > 0) {
             $argumentsAsString = [];
             foreach ($attribute->getArguments() as $argumentName => $argumentValue) {
-                $renderedArgumentValue = var_export($argumentValue, true);
+                $argumentAsString = self::renderAttributeArgumentValue($argumentValue);
                 if (is_numeric($argumentName)) {
-                    $argumentsAsString[] = $renderedArgumentValue;
+                    $argumentsAsString[] = $argumentAsString;
                 } else {
-                    $argumentsAsString[] = "$argumentName: $renderedArgumentValue";
+                    $argumentsAsString[] = "$argumentName: $argumentAsString";
                 }
             }
             $attributeAsString .= '(' . implode(', ', $argumentsAsString) . ')';
         }
         return "#[$attributeAsString]";
     }
 
+    private static function renderAttributeInstantiation(ReflectionAttribute $attribute): string
+    {
+        $attributeAsString = '\\' . $attribute->getName() . ':' . get_debug_type($attribute) ;
+        if (count($attribute->getArguments()) > 0) {
+            $argumentsAsString = [];
+            foreach ($attribute->getArguments() as $argumentName => $argumentValue) {
+                $argumentAsString = self::renderAttributeArgumentValue($argumentValue);
+                if (is_numeric($argumentName)) {
+                    $argumentsAsString[] = $argumentAsString;
+                } else {
+                    $argumentsAsString[] = "$argumentName: $argumentAsString";
+                }
+            }
+            $attributeAsString .= '(' . implode(', ', $argumentsAsString) . ')';
+        } else {
+            $attributeAsString .= '()';
+        }
+        return "new $attributeAsString";
+    }
+
+    private static function renderAttributeArgumentValue(mixed $attributeArgumentValue): string
+    {
+        if (is_object($attributeArgumentValue)) {
+            $reflectionClass = new ReflectionClass($attributeArgumentValue);
+            if ($reflectionClass->isEnum()) {
+                return '\\' . $reflectionClass->getName() . '::' . $attributeArgumentValue->name;
+            } else {
+                $fullyQualifiedName = '\\' . $reflectionClass->getName();
+                $constructor = $reflectionClass->getConstructor();
+                if (!$constructor) {
+                    return "new {$fullyQualifiedName}()";
+                }
+
+                // Try to reconstruct named arguments by matching constructor parameter names
+                // to public properties or getters ... this is obviously not perfect but probably
+                // ok in most attributes
+                $constructorParameters = [];
+                foreach ($constructor->getParameters() as $parameter) {
+                    $parameterName = $parameter->getName();
+                    $parameterValue = null;
+                    if ($reflectionClass->hasProperty($parameterName) && $reflectionClass->getProperty($parameterName)->isPublic()) {
+                        $parameterValue = $attributeArgumentValue->$parameterName;
+                    } else {
+                        $getterMethodName = 'get' . ucfirst($parameterName);
+                        if ($reflectionClass->hasMethod($getterMethodName) && $reflectionClass->getMethod($getterMethodName)->isPublic()) {
+                            $parameterValue = $attributeArgumentValue->$getterMethodName();
+                        }
+                    }
+                    if ($parameter->isDefaultValueAvailable()) {
+                        $parameterDefaultValue = $parameter->getDefaultValue();
+                        if ($parameterDefaultValue !== $parameterValue) {
+                            $parameterValueAsString = self::renderAttributeArgumentValue($parameterValue);
+                            $constructorParameters[$parameterName] = "{$parameterName}: {$parameterValueAsString}";
+                        }
+                    } else {
+                        $parameterValueAsString = self::renderAttributeArgumentValue($parameterValue);
+                        $constructorParameters[$parameterName] = "{$parameterName}: {$parameterValueAsString}";
+                    }
+                }
+
+                return "new {$fullyQualifiedName}(" . implode(', ', $constructorParameters) . ")";
+            }
+        } elseif (is_array($attributeArgumentValue)) {
+            $argumentsAsString = [];
+            foreach ($attributeArgumentValue as $key => $value) {
+                $argumentAsString = self::renderAttributeArgumentValue($value);
+                if (is_numeric($key)) {
+                    $argumentsAsString[] = $argumentAsString;
+                } else {
+                    $argumentsAsString[] = "'$key' => $argumentAsString";
+                }
+            }
+            return '[' . implode(', ', $argumentsAsString) . ']';
+        }
+        return var_export($attributeArgumentValue, true);
+    }
+
     /**
      * Render the source (string) form of an Annotation instance.
      *