Added test for nerc-rates loading. Mocks nerc-rates integration, sets up mock outages, creates test data, verifies call is called with correct parameters, verifies output is actually reflects reduced hours

Author: jimmysway

src/coldfront_plugin_cloud/tests/unit/test_calculate_quota_unit_hours.py

@@ -1,6 +1,8 @@
+import csv
 import datetime
 import pytz
 import tempfile
+from decimal import Decimal
 from unittest.mock import patch
 
 import freezegun
@@ -604,3 +606,67 @@ def test_load_excluded_intervals_invalid(self):
         ]
         with self.assertRaises(AssertionError):
             utils.load_excluded_intervals(invalid_interval)
+
+    @patch(
+        "coldfront_plugin_cloud.management.commands.calculate_storage_gb_hours.get_rates"
+    )
+    @patch("coldfront_plugin_cloud.utils.load_outages_from_nerc_rates")
+    def test_calculate_storage_loads_nerc_outages(
+        self, mock_load_outages, mock_rates_loader
+    ):
+        """Test calculate_storage_gb_hours loads outages from nerc-rates with correct parameters."""
+        mock_outages = [
+            (
+                pytz.utc.localize(datetime.datetime(2020, 3, 10, 0, 0, 0)),
+                pytz.utc.localize(datetime.datetime(2020, 3, 12, 0, 0, 0)),
+            )
+        ]
+        mock_load_outages.return_value = mock_outages
+        mock_rates_loader.return_value.get_value_at.return_value = Decimal("0.001")
+
+        resource = self.new_openstack_resource(name="NERC")
+        with freezegun.freeze_time("2020-03-01"):
+            user = self.new_user()
+            project = self.new_project(pi=user)
+            allocation = self.new_allocation(project, resource, 100)
+            utils.set_attribute_on_allocation(
+                allocation, attributes.ALLOCATION_PROJECT_NAME, "test"
+            )
+            utils.set_attribute_on_allocation(
+                allocation, attributes.ALLOCATION_PROJECT_ID, "123"
+            )
+            utils.set_attribute_on_allocation(
+                allocation, attributes.QUOTA_VOLUMES_GB, 10
+            )
+
+        with tempfile.NamedTemporaryFile(mode="w", delete=False, suffix=".csv") as fp:
+            output_file = fp.name
+
+        call_command(
+            "calculate_storage_gb_hours",
+            "--output",
+            output_file,
+            "--start",
+            "2020-03-01",
+            "--end",
+            "2020-03-31",
+            "--invoice-month",
+            "2020-03",
+        )
+
+        # Verify load_outages_from_nerc_rates was called with correct parameters
+        start = pytz.utc.localize(datetime.datetime(2020, 3, 1, 0, 0, 0))
+        end = pytz.utc.localize(datetime.datetime(2020, 3, 31, 0, 0, 0))
+        mock_load_outages.assert_called_once_with(start, end, "stack")
+
+        # Verify the mocked outages were actually used to reduce billable hours
+        with open(output_file, "r") as f:
+            reader = csv.DictReader(f)
+            rows = list(reader)
+
+        self.assertEqual(len(rows), 1)
+        billable_hours = int(rows[0]["SU Hours (GBhr or SUhr)"])
+        expected_hours = (
+            (30 - 2) * 24 * 10
+        )  # 28 days × 24 hrs/day × 10 GB = 6,720 GB-hours
+        self.assertEqual(billable_hours, expected_hours)