We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, in rasteriza_indices_in_range.cu and rasterize_to_pixels_fwd.cu I noticed that while counting valid Gaussians, https://github.com/nerfstudio-project/gsplat/blob/0880d2b471e6650d458aa09fe2b2834531f6e93b/gsplat/cuda/csrc/rasterize_to_indices_in_range.cu#L148-L153C14
This Gaussian is not counted when break is used, but it should be counted as it has a transmittance>1e-4. I referred to the original 3dgs code they used continue instead of break https://github.com/graphdeco-inria/diff-gaussian-rasterization/blob/9c5c2028f6fbee2be239bc4c9421ff894fe4fbe0/cuda_rasterizer/forward.cu#L363C1-L369C1
break
continue
Is this an error in the implementation or am I missing something?
Thanks!
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi, in rasteriza_indices_in_range.cu and rasterize_to_pixels_fwd.cu I noticed that while counting valid Gaussians,
https://github.com/nerfstudio-project/gsplat/blob/0880d2b471e6650d458aa09fe2b2834531f6e93b/gsplat/cuda/csrc/rasterize_to_indices_in_range.cu#L148-L153C14
This Gaussian is not counted when
break
is used, but it should be counted as it has a transmittance>1e-4. I referred to the original 3dgs code they usedcontinue
instead ofbreak
https://github.com/graphdeco-inria/diff-gaussian-rasterization/blob/9c5c2028f6fbee2be239bc4c9421ff894fe4fbe0/cuda_rasterizer/forward.cu#L363C1-L369C1
Is this an error in the implementation or am I missing something?
Thanks!
The text was updated successfully, but these errors were encountered: