Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A possible mistake in the rasterization cuda code? #556

Open
TeCai opened this issue Feb 11, 2025 · 0 comments
Open

A possible mistake in the rasterization cuda code? #556

TeCai opened this issue Feb 11, 2025 · 0 comments

Comments

@TeCai
Copy link

TeCai commented Feb 11, 2025

Hi, in rasteriza_indices_in_range.cu and rasterize_to_pixels_fwd.cu I noticed that while counting valid Gaussians,
https://github.com/nerfstudio-project/gsplat/blob/0880d2b471e6650d458aa09fe2b2834531f6e93b/gsplat/cuda/csrc/rasterize_to_indices_in_range.cu#L148-L153C14

This Gaussian is not counted when break is used, but it should be counted as it has a transmittance>1e-4. I referred to the original 3dgs code they used continue instead of break
https://github.com/graphdeco-inria/diff-gaussian-rasterization/blob/9c5c2028f6fbee2be239bc4c9421ff894fe4fbe0/cuda_rasterizer/forward.cu#L363C1-L369C1

Is this an error in the implementation or am I missing something?

Thanks!

@TeCai TeCai changed the title A question regards the rasterization cuda code A possible mistake in the rasterization cuda code? Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant