Update test suite

Author: Aaron Hicks

.fixtures.yml

@@ -1,5 +1,7 @@
 fixtures:
-  repositories:
-    stdlib: "git://github.com/puppetlabs/puppetlabs-stdlib.git"
+  forge_modules:
+    stdlib:
+      repo: 'puppetlabs-stdlib'
+      ref:  '4.6.0'
   symlinks:
-    rrd: "#{source_dir}"
+    ganglia: "#{source_dir}"

.gitattributes

@@ -0,0 +1,26 @@
+# Set the default behavior, in case people don't have core.autocrlf set.
+* text=auto
+
+# Explicitly declare text files you want to always be normalized and converted
+# to native line endings on checkout.
+# *.c text
+# *.h text
+
+# Declare files that will always have LF line endings on checkout.
+*.pp text eol=lf linguist-language=Puppet
+*.rb text eol=lf
+*.md text eol=lf
+*.yml text eol=lf
+*.erb text eol=lf linguist-language=Ruby
+*.conf text eol=lf linguist-language=INI
+*.markdown text eol=lf
+Gemfile text eol=lf
+Rakefile text eol=lf
+
+# Declare files that will always have CRLF line endings on checkout.
+*.sln text eol=crlf
+*.ps1 text eol=crlf
+
+# Denote all files that are truly binary and should not be modified.
+*.png binary
+*.jpg binary

.travis.yml

@@ -1,27 +1,72 @@
 language: ruby
-bundler_args: --without development
-script: "bundle exec rake spec SPEC_OPTS='--format documentation'"
+sudo: false
+
+before_script:
+  - bundle exec metadata-json-lint metadata.json
+  - bundle exec rake validate_ruby_syntax
+  - bundle exec rake check_line_endings
+  - bundle exec rake syntax
+  - bundle exec rake lint
+
+script:
+  - bundle exec rake spec SPEC_OPTS='--format documentation'
+
 rvm:
   - 1.8.7
   - 1.9.3
-  - ruby-head
+  - 2.0.0
+  - 2.1.1
+
 env:
+  matrix:
   - PUPPET_GEM_VERSION="~> 2.6.0"
   - PUPPET_GEM_VERSION="~> 2.7.0"
   - PUPPET_GEM_VERSION="~> 3.0.0"
   - PUPPET_GEM_VERSION="~> 3.1.0"
+  - PUPPET_GEM_VERSION="~> 3.2.0"
+  - PUPPET_GEM_VERSION="~> 3.3.0"
+  - PUPPET_GEM_VERSION="~> 3.4.0"
+  - PUPPET_GEM_VERSION="~> 3.5.0"
+  - PUPPET_GEM_VERSION="~> 3.5.0" STRICT_VARIABLES="yes"
+  - PUPPET_GEM_VERSION="~> 3.6.0"
+  - PUPPET_GEM_VERSION="~> 3.6.0" STRICT_VARIABLES="yes"
+  - PUPPET_GEM_VERSION="~> 3.7.0"
+  - PUPPET_GEM_VERSION="~> 3.7.0" STRICT_VARIABLES="yes"
+
 matrix:
+  fast_finish: true
   allow_failures:
-    - rvm: ruby-head
     - env: PUPPET_GEM_VERSION="~> 2.6.0"
+    - env: PUPPET_GEM_VERSION="~> 2.7.0"
+    - env: PUPPET_GEM_VERSION="~> 3.0.0"
+    - env: PUPPET_GEM_VERSION="~> 3.1.0"
   exclude:
     - rvm: 1.9.3
       env: PUPPET_GEM_VERSION="~> 2.7.0"
-    - rvm: ruby-head
-      env: PUPPET_GEM_VERSION="~> 2.7.0"
     - rvm: 1.9.3
       env: PUPPET_GEM_VERSION="~> 2.6.0"
-    - rvm: ruby-head
+    - rvm: 2.0.0
+      env: PUPPET_GEM_VERSION="~> 2.6.0"
+    - rvm: 2.0.0
+      env: PUPPET_GEM_VERSION="~> 2.7.0"
+    - rvm: 2.0.0
+      env: PUPPET_GEM_VERSION="~> 3.0.0"
+    - rvm: 2.0.0
+      env: PUPPET_GEM_VERSION="~> 3.1.0"
+    - rvm: 2.1.1
       env: PUPPET_GEM_VERSION="~> 2.6.0"
+    - rvm: 2.1.1
+      env: PUPPET_GEM_VERSION="~> 2.7.0"
+    - rvm: 2.1.1
+      env: PUPPET_GEM_VERSION="~> 3.0.0"
+    - rvm: 2.1.1
+      env: PUPPET_GEM_VERSION="~> 3.1.0"
+    - rvm: 2.1.1
+      env: PUPPET_GEM_VERSION="~> 3.2.0"
+    - rvm: 2.1.1
+      env: PUPPET_GEM_VERSION="~> 3.3.0"
+    - rvm: 2.1.1
+      env: PUPPET_GEM_VERSION="~> 3.4.0"
+
 notifications:
-  email: false
+  email: false

Gemfile

@@ -1,13 +1,19 @@
 source 'https://rubygems.org'
 
-group :development, :test do
-  gem 'puppetlabs_spec_helper', :require => false
-end
+gem 'metadata-json-lint'
+gem 'rspec-puppet-facts'
+gem 'puppetlabs_spec_helper', '>= 0.1.0'
+gem 'puppet-lint',            '>= 1.0.0'
 
 if puppetversion = ENV['PUPPET_GEM_VERSION']
-  gem 'puppet', puppetversion, :require => false
+  gem 'puppet', puppetversion
 else
-  gem 'puppet', :require => false
+  gem 'puppet'
+end
+
+# rspec must be v2 for ruby 1.8.7
+if RUBY_VERSION >= '1.8.7' and RUBY_VERSION < '1.9'
+  gem 'rspec', '~> 2.0'
 end
 
-# vim:ft=ruby
+# vim:ft=ruby

Modulefile

@@ -1 +1,53 @@
 require 'puppetlabs_spec_helper/rake_tasks'
+require 'puppet-lint/tasks/puppet-lint'
+require 'puppet-syntax/tasks/puppet-syntax'
+
+exclude_paths = [
+  'spec/**/*',
+  'pkg/**/*',
+  'tests/**/*'
+]
+
+PuppetSyntax.exclude_paths = exclude_paths
+
+Rake::Task[:lint].clear
+PuppetLint::RakeTask.new :lint do |config|
+  # Pattern of files to ignore
+  config.ignore_paths = exclude_paths
+
+  # List of checks to disable
+  config.disable_checks = [
+    '80chars',
+    'class_parameter_defaults',
+    'class_inherits_from_params_class',
+    'autoloader_layout'
+  ]
+
+  # Should the task fail if there were any warnings, defaults to false
+  config.fail_on_warnings = true
+
+  # Print out the context for the problem, defaults to false
+  config.with_context = true
+
+  # Format string for puppet-lint's output (see the puppet-lint help output
+  # for details
+  config.log_format = "%{path}:%{linenumber}:%{check}:%{KIND}:%{message}"
+
+  # Compare module layout relative to the module root
+  # config.relative = true
+end
+
+desc 'Check for ruby syntax errors.'
+task :validate_ruby_syntax do
+  ruby_parse_command = 'ruby -c'
+  Dir['spec/**/*.rb'].each do |path|
+   sh "#{ruby_parse_command} #{path}"
+  end
+end
+
+desc 'Check for evil line endings.'
+task :check_line_endings do
+  Dir['spec/**/*.rb','manifests/**/*.pp','tests/**/*.pp'].each do |path|
+   sh "file #{path}|grep -v CRLF"
+  end
+end

Rakefile

@@ -0,0 +1,50 @@
+{
+  "name": "Aethylred-rrd",
+  "version": "0.1.0",
+  "summary": "A Puppet Module to install and configure the Round Robin Database tools, cache and bindings.",
+  "author": "Aethylred",
+  "description": "This is a Puppet Module for installing and configuring the [Round Robin Database](http://oss.oetiker.ch/rrdtool/) tools, cache, and bindings.",
+  "dependencies": [
+    {
+      "name": "puppetlabs/stdlib",
+      "version_requirement": ">=3.2.0 <5.0.0"
+    }
+  ],
+  "source": "https://github.com/nesi/puppet-rrd",
+  "project_page": "https://github.com/nesi/puppet-rrd",
+  "issues_url": "https://github.com/nesi/puppet-rrd/issues",
+  "license": "Apache-2.0",
+  "operatingsystem_support": [
+    {
+      "operatingsystem": "Debian",
+      "operatingsystemrelease": [
+        "6",
+        "7"
+      ]
+    },
+    {
+      "operatingsystem": "Ubuntu",
+      "operatingsystemrelease": [
+        "10.04",
+        "12.04",
+        "14.04"
+      ]
+    },
+    {
+      "operatingsystem": "RedHat",
+      "operatingsystemrelease": [
+        "5",
+        "6",
+        "7"
+      ]
+    },
+    {
+      "operatingsystem": "CentOS",
+      "operatingsystemrelease": [
+        "5",
+        "6",
+        "7"
+      ]
+    }
+   ]
+}

metadata.json

@@ -1 +1,52 @@
 require 'puppetlabs_spec_helper/module_spec_helper'
+require 'rspec-puppet-facts'
+include RspecPuppetFacts
+
+RSpec.configure do |c|
+
+  c.treat_symbols_as_metadata_keys_with_true_values = true
+
+  c.before :each do
+    # Ensure that we don't accidentally cache facts and environment
+    # between test cases.
+    Facter::Util::Loader.any_instance.stubs(:load_all)
+    Facter.clear
+    Facter.clear_messages
+
+    # Store any environment variables away to be restored later
+    @old_env = {}
+    ENV.each_key {|k| @old_env[k] = ENV[k]}
+
+    if ENV['STRICT_VARIABLES'] == 'yes'
+      Puppet.settings[:strict_variables]=true
+    end
+  end
+end
+
+shared_examples :compile, :compile => true do
+  it { should compile.with_all_deps }
+end
+
+$supported_os = on_supported_os.map do |os, facts|
+  os_expects = {}
+  expects = {
+
+  }
+  case facts[:osfamily]
+  when 'Debian'
+    expects.merge!( {
+
+    } )
+  when 'RedHat'
+    expects.merge!( {
+
+    } )
+  end
+
+  os_expects = {
+    :os      => os,
+    :facts   => facts,
+    :expects => expects
+  }
+  os_expects
+end